Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(semantic): correct typo in doc comment #5009

Merged
merged 1 commit into from
Aug 20, 2024
Merged

refactor(semantic): correct typo in doc comment #5009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/oxc_semantic/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ impl<'a> SemanticBuilder<'a> {
}

/// Check if a symbol with the same name has already been declared in the
/// current scope. Returns the symbol id if it exists and is not excluded by `excludes`.
/// current scope. Returns the symbol ID if it exists and is not excluded by `excludes`.
///
/// Only records a redeclaration error if `report_error` is `true`.
pub(crate) fn check_redeclaration(
Expand Down Expand Up @@ -455,7 +455,7 @@ impl<'a> SemanticBuilder<'a> {
/// Try to resolve all references from the current scope that are not
/// already resolved.
///
/// This gets called every time [`SemanticBuilder`] exists a scope.
/// This gets called every time [`SemanticBuilder`] exits a scope.
fn resolve_references_for_current_scope(&mut self) {
let (current_refs, parent_refs) = self.unresolved_references.current_and_parent_mut();

Expand Down Expand Up @@ -1728,7 +1728,7 @@ impl<'a> SemanticBuilder<'a> {

match kind {
AstKind::ExportDefaultDeclaration(decl) => {
// Only if the declaration has an id, we mark it as an export
// Only if the declaration has an ID, we mark it as an export
if match &decl.declaration {
ExportDefaultDeclarationKind::FunctionDeclaration(ref func) => {
func.id.is_some()
Expand Down