Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(semantic): transform checker check unbound references #5093

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix(semantic): transform checker check unbound references #5093

merged 1 commit into from
Aug 23, 2024

Conversation

overlookmotel
Copy link
Contributor

No description provided.

@github-actions github-actions bot added A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler labels Aug 22, 2024
This was referenced Aug 22, 2024
Merged
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Aug 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel marked this pull request as ready for review August 22, 2024 18:49
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 22, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5093 will not alter performance

Comparing 08-22-fix_semantic_transform_checker_check_unbound_references (c57e078) with main (0b90011)

Summary

✅ 29 untouched benchmarks

This was referenced Aug 22, 2024
Merged
Merged
Merged
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 22, 2024 — with Graphite App
@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 22, 2024 •
edited
Loading

Merge activity

  • Aug 22, 7:39 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Aug 22, 7:52 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #5092.
  • Aug 22, 7:52 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #5092.
  • Aug 22, 8:16 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 22, 8:23 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 22, 8:32 PM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Aug 23, 3:40 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 23, 3:45 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 23, 3:46 AM EDT: overlookmotel merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 08-22-fix_semantic_transform_checker_check_reference_flags branch from d3923ff to d145370 Compare August 22, 2024 23:43
Boshen pushed a commit that referenced this pull request Aug 22, 2024
@overlookmotel
fix(semantic): transform checker check unbound references (#5093)
ce67a76
@Boshen Boshen force-pushed the 08-22-fix_semantic_transform_checker_check_unbound_references branch from 0d8eff5 to ce67a76 Compare August 22, 2024 23:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 22, 2024
@overlookmotel overlookmotel force-pushed the 08-22-fix_semantic_transform_checker_check_reference_flags branch from d145370 to 946925e Compare August 23, 2024 00:12
overlookmotel added a commit that referenced this pull request Aug 23, 2024
@overlookmotel
fix(semantic): transform checker check unbound references (#5093)
0dd513a
@overlookmotel overlookmotel force-pushed the 08-22-fix_semantic_transform_checker_check_unbound_references branch from ce67a76 to 0dd513a Compare August 23, 2024 00:14
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 23, 2024
@overlookmotel overlookmotel changed the base branch from 08-22-fix_semantic_transform_checker_check_reference_flags to graphite-base/5093 August 23, 2024 00:21
@overlookmotel overlookmotel changed the base branch from graphite-base/5093 to main August 23, 2024 00:31
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 23, 2024
@overlookmotel overlookmotel force-pushed the 08-22-fix_semantic_transform_checker_check_unbound_references branch from 0dd513a to c57e078 Compare August 23, 2024 07:39
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 23, 2024
@overlookmotel
Copy link
Contributor Author

Goddamn it Graphite! Will you please merge this thing?!

@graphite-app graphite-app bot merged commit c57e078 into main Aug 23, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 08-22-fix_semantic_transform_checker_check_unbound_references branch August 23, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overlookmotel @Boshen