refactor(linter): eslint/no_redeclare rule use run_on_symbol not run_once
#5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #5201 will not alter performanceComparing Summary
|
overlookmotel
changed the title
NoRedeclare rule use run_on_symbol not run_onceeslint/no_redeclare rule use run_on_symbol not run_once
|
I had expected this to produce a small perf gain, as it avoids an extra round of iterating through all symbols, but it's actually showing as marginally slower, rather than faster. I don't know how much variance there is in linter benchmarks - possible the apparent perf drop is just noise in the benchmark? Or is it likely for real? |
|
I merged main branch in and now benchmark says it's faster! I guess it is just noise in the benchmarks... |
DonIsaac
approved these changes
Aug 25, 2024
Merge activity
|
…`run_once` (#5201) `eslint/no_redeclare` rule iterates over all symbols. Use `run_on_symbols` for this, instead of `run_once`.
DonIsaac
force-pushed
the
08-25-refactor_linter_noredeclare_rule_use_run_on_symbol_not_run_once_
branch
from
0295f9e to
2a91ef1
Compare
graphite-app
bot
deleted the
08-25-refactor_linter_noredeclare_rule_use_run_on_symbol_not_run_once_
branch
Merged
Boshen
added a commit
that referenced
this pull request
Aug 26, 2024
## [0.9.0] - 2024-08-26 - 5946748 linter: [**BREAKING**] Parse and display syntax errors for regular expressions (#5214) (Boshen) - b894d3b linter: [**BREAKING**] Make `no-unused-vars` correctness (#5081) (DonIsaac) ### Features - 1ce9630 linter/config: Implement FromIterator for LintPluginOptions (#5102) (DonIsaac) - 34bfaf6 linter/react: Add fixer to `jsx-props-no-spread-multi` (#5145) (camc314) - 982bd6e linter/unicorn: Add fixer to `require-array-join-separator` (#5152) (camc314) - a6704bd linter/unicorn: Add fixer to `prefer-set-size` (#5149) (camc314) - ac7edcc linter/unicorn: Add fixer to `prefer-array-some` (#5153) (camc314) - 1d01aa3 linter/unicorn: Add partial fixer for `prefer-array-flat` (#5143) (camc314) - 22d57f9 linter/unicorn: Add fixer to `prefer-string-slice` (#5150) (Cameron) - 2fe4415 linter/unicorn: Add fixer to `no-redundant-roles` (#5146) (Cameron) - d35c6f5 linter/unicorn: Add fixer to `prefer-regexp-test` (#5151) (Cameron) - 27db769 linter/unicorn: Add fixer to `text-encoding-identifier-case` (#5154) (Cameron) - f7958c4 linter/unicorn: Add prefer-structured-clone (#5095) (Jelle van der Waa) - 004ffa0 linter/vitest: Implement `prefer-each` (#5203) (dalaoshu) ### Bug Fixes - aaaf26c linter: Error in fixer for prefer-to-have-length (#5197) (dalaoshu) - 1f5b6b6 linter: Bug in fixer for prefer-to-have-length (#5164) (dalaoshu) - 7eb052e linter: `no-hex-escape` fixer removing regex flags (#5137) (Cameron) - 76c66b4 linter/max-lines: Point span to end of file for disable directive to work (#5117) (Boshen) - 8ff6f2c linter/no-unused-vars: Panic on UsingDeclarations (#5206) (DonIsaac) - d29042e linter/no-unused-vars: Function expression in implicit arrow function return (#5155) (DonIsaac) - 36e4a28 linter/no-unused-vars: Panic in variable declarator usage checks (#5160) (DonIsaac) - ba62a71 linter/react: Fixed false positive with missing key inside React.Children.toArray() for fragments (#5133) (Earl Chase) - fd1031a linter/unicorn: Breaking fixer in case statements for `no-null` (#5176) (DonIsaac) - 7b86ed6 linter/unicorn: Handle type casts and parens in `no-null` (#5175) (Don Isaac) - b629e16 linter/unicorn: Improve diagnostic message for `no-null` (#5172) (DonIsaac) ### Performance - ce454cf Use simdutf8 to validate UTF-8 when reading files (#5196) (dalaoshu) ### Refactor - 543cad6 codegen: Remove some pub APIs (Boshen) - 0d3661a linter: Remove meaningless `span0` (#5209) (dalaoshu) - 2a91ef1 linter: `eslint/no_redeclare` rule use `run_on_symbol` not `run_once` (#5201) (overlookmotel) - 33599b0 linter: Split options into multiple files (#5101) (DonIsaac) - 7ab6152 linter/unicorn: Clean up `no-null` (#5174) (DonIsaac) ### Testing - a877e5a linter/no-unused-vars: Ensure type annotations on property accessors are considered used (#5183) (DonIsaac) - 7886618 linter/unicorn: Add fixer tests for `no-null` (#5173) (DonIsaac) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint/no_redeclarerule iterates over all symbols. Userun_on_symbolsfor this, instead ofrun_once.