-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(linter): add LintFilter
#5329
refactor(linter): add LintFilter
#5329
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #5329 will degrade performances by 4.72%Comparing Summary
Benchmarks breakdown
|
54b11b5
to
1c556df
Compare
c2f27a0
to
eb7c9b9
Compare
1c556df
to
f4881bd
Compare
f4881bd
to
a512edc
Compare
Formalizes
(AllowWarnDeny, String)
intoLintFilter
andLintFilterKind
.Filters can be one of three variants:
category
: for enabling/disabling an entire category. Corresponds to stringsthat are parseable into
RuleCategory
rule
: for enabling/disabling an single rule. This variant also stores theplugin name. Corresponds to the string
<plugin>/<rule>
generic
: everything else."all"
falls under this one.Note that if users use
<plugin>/<rule>
filters that are malformed,oxlint
will now error. Missing plugins (e.g. for
vue/foobar
will have their pluginsparsed as "eslint" and fail silently. This is consistent with current behavior.