Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast)!: add ThisExpression variants to JSXElementName and JSXMemberExpressionObject (#5466) #5471

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Sep 5, 2024

feat(ast)!: add ThisExpression variants to JSXElementName and JSXMemberExpressionObject (#5466)

Close #5352.

Add to AST:

  • JSXElementName::ThisExpression (<this>)
  • JSXMemberExpressionObject::ThisExpression (<this.foo>, <this.foo.bar>)

fix(linter/tree-shaking): detect the correct export symbol resolution (#5467)

fixes: #5455

feat(ast): add ContentHash trait; remove noop Hash implementation from Span (#5451)

closes #5283

Also removes the noop Hash implementation on Span in favor of a real implementation.

refactor(ast, ast_tools): use full method path for generated derives trait calls. (#5462)

As of now if we remove the implementation of a trait for a type and implement the method on that type directly it wouldn't break while it isn't the original trait anymore so that method might do something entirely different.
This change is more explicit on trait calls so we hit compile errors on these kinds of changes.

refactor(ast): simplify ContentEq trait definition. (#5468)

Addresses the concerns brought up in #5427

fix(ast, codegen, linter): panics in fixers. (#5431)

Closes #5434

https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/10685877915/job/29619941099

fix(regex): panic on displaying surrogated UnicodeEscape characters. (#5469)

fixes #5387 (comment)

Merge remote-tracking branch 'origin/main' into 09-05-feat_transformer_support_all__regex__to_new_regexp_transforms

update snapshot

Copy link
Member Author

Dunqing commented Sep 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Sep 5, 2024
@Dunqing Dunqing closed this Sep 5, 2024
Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #5471 will degrade performances by 13.86%

Comparing 09-05-feat_transformer_support_all__regex__to_new_regexp_transforms (ba0f3d0) with main (9b984b3)

Summary

❌ 2 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 09-05-feat_transformer_support_all__regex__to_new_regexp_transforms Change
transformer[antd.js] 27.7 ms 32.2 ms -13.86%
transformer[pdf.mjs] 10.2 ms 10.7 ms -4.92%

Copy link

graphite-app bot commented Sep 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
2 participants