refactor(transformer): clarify match in RegExp transform

[overlookmotel]

Refactor match on Term in RegExp transform.

This is personal taste, really. I prefer this style:

match enum {
    Enum::Variant(x) => x.is_something(),
    _ => false,
}

over:

match enum {
    Enum::Variant(x) if x.is_something() => true,
    _ => false,
}

because then you don't have to reason about what happens when the if is false and it "falls through" to the next match arm. The compiler might also find the former easier to optimize, though likely in most cases it can figure out that they're equivalent.

Also rename a couple of vars for clarity.

[overlookmotel]

• refactor(transformer): re-order imports #5499
• refactor(transformer): clarify match in RegExp transform #5498 👈
• refactor(transformer): RegExp transform report pattern parsing errors #5496
• fix(transformer): RegExp transform do not transform invalid regexps #5494
• refactor(transformer): RegExp transform do not take ownership of Pattern then reallocate it #5492
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #5498 will not alter performance

_{Comparing 09-05-refactor_transformer_clarify_match_in_regexp_transform (6abde0a) with main (64db1b4)}

Summary

✅ 29 untouched benchmarks

[graphite-app]

Merge activity

• Sep 5, 12:04 PM EDT: Dunqing added this pull request to the Graphite merge queue.
• Sep 5, 12:14 PM EDT: Dunqing merged this pull request with the Graphite merge queue.