Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(traverse): UIDs cache store used names as FxHashSet instead of Vec #5623

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Sep 8, 2024

Follow-on after #5611. Store existing var names in uid_names as FxHashSet instead of a Vec.

WIP. Not sure if this will improve perf or not, since often the Vecs would have few entries.

Copy link

graphite-app bot commented Sep 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

overlookmotel commented Sep 8, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel marked this pull request as ready for review September 8, 2024 22:17
@overlookmotel overlookmotel marked this pull request as draft September 8, 2024 22:17
Copy link

codspeed-hq bot commented Sep 8, 2024

CodSpeed Performance Report

Merging #5623 will not alter performance

Comparing 09-08-perf_traverse_uids_cache_store_used_names_as_fxhashset_instead_of_vec_ (12b0738) with 09-08-perf_traverse_generate_uid_cache_available_binding_names (c7c4d6f)

Summary

✅ 29 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant