Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): move run_once to the end #5741

Conversation

shulaoda
Copy link
Contributor

Related to #5204

Copy link

graphite-app bot commented Sep 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Sep 13, 2024
Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #5741 will not alter performance

Comparing shulaoda:feat/support-run-once-at-end-for-linter (e39e71c) with main (cc0408b)

Summary

✅ 29 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Sep 13, 2024

It feels like moving run_once to the end should make things work.

@shulaoda
Copy link
Contributor Author

It feels like moving run_once to the end should make things work.

Good idea!

@shulaoda shulaoda changed the title feat(linter): support run_once_at_end feat(linter): move run_once to the end Sep 13, 2024
@shulaoda shulaoda changed the title feat(linter): move run_once to the end refactor(linter): move run_once to the end Sep 13, 2024
@Boshen
Copy link
Member

Boshen commented Sep 13, 2024

We can defer merging this until we figure out how to store rule states.

@shulaoda shulaoda marked this pull request as draft September 13, 2024 04:36
@DonIsaac
Copy link
Contributor

We can defer merging this until we figure out how to store rule states.

How would you feel about a cache object for each rule stored in LintContext?

@Boshen Boshen marked this pull request as ready for review September 13, 2024 15:27
@Boshen Boshen marked this pull request as draft September 13, 2024 15:27
@Boshen
Copy link
Member

Boshen commented Sep 13, 2024

We can defer merging this until we figure out how to store rule states.

How would you feel about a cache object for each rule stored in LintContext?

Can give this a try.

@Boshen Boshen closed this Sep 25, 2024
@shulaoda shulaoda deleted the feat/support-run-once-at-end-for-linter branch September 25, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants