perf(transformer): nullish coalescing operator transform use SparseStack
#5942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Sep 21, 2024
CodSpeed Performance ReportMerging #5942 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
09-21-fix_transformer_arrow_function_transform_prevent_stack_getting_out_of_sync
branch
from
a2bace9
to
d00d939
Compare
overlookmotel
force-pushed
the
09-21-perf_transformer_nullish_coalescing_operator_transform_use_sparsestack_
branch
from
52fbd61
to
0f48e19
Compare
overlookmotel
force-pushed
the
09-21-fix_transformer_arrow_function_transform_prevent_stack_getting_out_of_sync
branch
from
d00d939
to
fcf4d29
Compare
overlookmotel
force-pushed
the
09-21-perf_transformer_nullish_coalescing_operator_transform_use_sparsestack_
branch
from
0f48e19
to
c1c72fc
Compare
Boshen
force-pushed
the
09-21-fix_transformer_arrow_function_transform_prevent_stack_getting_out_of_sync
branch
from
fcf4d29
to
824ebab
Compare
Boshen
force-pushed
the
09-21-perf_transformer_nullish_coalescing_operator_transform_use_sparsestack_
branch
from
c1c72fc
to
f8bfd5e
Compare
Boshen
force-pushed
the
09-21-fix_transformer_arrow_function_transform_prevent_stack_getting_out_of_sync
branch
from
824ebab
to
03c3db1
Compare
Boshen
force-pushed
the
09-21-perf_transformer_nullish_coalescing_operator_transform_use_sparsestack_
branch
from
f8bfd5e
to
9c37eba
Compare
overlookmotel
force-pushed
the
09-21-fix_transformer_arrow_function_transform_prevent_stack_getting_out_of_sync
branch
from
03c3db1
to
6d36544
Compare
overlookmotel
force-pushed
the
09-21-perf_transformer_nullish_coalescing_operator_transform_use_sparsestack_
branch
from
9c37eba
to
77988f9
Compare
overlookmotel
changed the base branch from
09-21-fix_transformer_arrow_function_transform_prevent_stack_getting_out_of_sync
to
09-20-perf_transformer_arrow_function_transform_reduce_stack_memory_usage
Dunqing
force-pushed
the
09-20-perf_transformer_arrow_function_transform_reduce_stack_memory_usage
branch
from
8cc4b35
to
0dedf32
Compare
Dunqing
force-pushed
the
09-21-perf_transformer_nullish_coalescing_operator_transform_use_sparsestack_
branch
from
77988f9
to
5cad15f
Compare
overlookmotel
force-pushed
the
09-20-perf_transformer_arrow_function_transform_reduce_stack_memory_usage
branch
from
0dedf32
to
5008b88
Compare
overlookmotel
force-pushed
the
09-21-perf_transformer_nullish_coalescing_operator_transform_use_sparsestack_
branch
from
5cad15f
to
779b470
Compare
Dunqing
force-pushed
the
09-20-perf_transformer_arrow_function_transform_reduce_stack_memory_usage
branch
2 times, most recently
from
ca3e3f6
to
8a6b2e5
Compare
Dunqing
force-pushed
the
09-21-perf_transformer_nullish_coalescing_operator_transform_use_sparsestack_
branch
from
779b470
to
30c86a0
Compare
overlookmotel
force-pushed
the
09-20-perf_transformer_arrow_function_transform_reduce_stack_memory_usage
branch
from
8a6b2e5
to
7e76547
Compare
overlookmotel
force-pushed
the
09-21-perf_transformer_nullish_coalescing_operator_transform_use_sparsestack_
branch
2 times, most recently
from
f8d633a
to
0abebf0
Compare
This was referenced Sep 21, 2024
Dunqing
approved these changes
Sep 23, 2024
Merge activity
|
Dunqing
force-pushed
the
09-20-perf_transformer_arrow_function_transform_reduce_stack_memory_usage
branch
from
7e76547
to
618e89e
Compare
Dunqing
force-pushed
the
09-21-perf_transformer_nullish_coalescing_operator_transform_use_sparsestack_
branch
from
0abebf0
to
5dc0154
Compare
Base automatically changed from
09-20-perf_transformer_arrow_function_transform_reduce_stack_memory_usage
to
main
September 23, 2024 07:57
graphite-app
bot
deleted the
09-21-perf_transformer_nullish_coalescing_operator_transform_use_sparsestack_
branch
Boshen
added a commit
that referenced
this pull request
Sep 24, 2024
## [0.30.1] - 2024-09-24 ### Features - 5c323a2 minifier: Loop compressor passes (#6013) (Boshen) ### Bug Fixes - 9ca202a codegen: Preserve newlines between comments (#6014) (Boshen) - 4a99372 codegen: Print jsdoc comments for `TSEnumMember`s (#6007) (camc314) - 97a2c41 isolated-declarations: False positive for class private getter with non-inferrable return type (#5987) (michaelm) ### Performance - 2b17003 linter, prettier, diagnostics: Use `FxHashMap` instead of `std::collections::HashMap` (#5993) (camchenry) - 7b90d79 transformer: `SparseStack` always keep minimum 1 entry (#5962) (overlookmotel) - 28fe80a transformer: Logical assignment operator transform use `SparseStack` (#5960) (overlookmotel) - 9f7d4b7 transformer: Exponentiation operator transform use `SparseStack` (#5959) (overlookmotel) - 5dc0154 transformer: Nullish coalescing operator transform use `SparseStack` (#5942) (overlookmotel) - 618e89e transformer: Arrow function transform: reduce stack memory usage (#5940) (overlookmotel) ### Documentation - 5a0d17c ast: Document more AST nodes (#6000) (DonIsaac) - 18371dd oxc: Include feature-guarded modules in docs.rs (#6012) (DonIsaac) - 1abfe8f semantic: Document `SymbolTable` (#5998) (DonIsaac) - f5eee72 semantic: Correct docs for `Reference` (#5992) (overlookmotel) - 860f108 transformer: Add to arrow functions transform docs (#5989) (overlookmotel) ### Refactor - 0a2f687 minifier: Move dce conditional expression to `RemoveDeadCode` (#5971) (Boshen) - f02bf51 transformer: Arrow function transform: remove unnecessary assertion (#6002) (overlookmotel) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
SparseStack(introduced in #5940) to store the stack of blocks which may need avar _temp;statement added to them. This reduces the memory required for the stack, on assumption that most blocks won't need avarstatement.