Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(linter): add regression test for #5227 #5975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

camchenry
Copy link
Collaborator

@camchenry camchenry commented Sep 22, 2024

Copy link

graphite-app bot commented Sep 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

camchenry commented Sep 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-linter Area - Linter label Sep 22, 2024
@camchenry camchenry force-pushed the 09-22-feat_linter_add_unicode_sets_support_to_no-useless-escape_rule branch from e3284da to 9eb678f Compare September 22, 2024 19:04
@camchenry camchenry force-pushed the 09-22-test_linter_add_regression_test_for_5227 branch from ae0b29c to 5043e22 Compare September 22, 2024 19:06
@camchenry camchenry marked this pull request as ready for review September 22, 2024 19:06
Copy link

codspeed-hq bot commented Sep 22, 2024

CodSpeed Performance Report

Merging #5975 will not alter performance

Comparing 09-22-test_linter_add_regression_test_for_5227 (b56511f) with main (74d8714)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Sep 22, 2024
Copy link

graphite-app bot commented Sep 22, 2024

Merge activity

  • Sep 22, 5:06 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 22, 5:19 PM EDT: DonIsaac added this pull request to the Graphite merge queue.
  • Sep 22, 5:25 PM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Sep 22, 5:30 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@DonIsaac DonIsaac linked an issue Sep 22, 2024 that may be closed by this pull request
@camchenry camchenry force-pushed the 09-22-feat_linter_add_unicode_sets_support_to_no-useless-escape_rule branch from 9eb678f to b0a405e Compare September 22, 2024 21:13
@camchenry camchenry force-pushed the 09-22-test_linter_add_regression_test_for_5227 branch from 5043e22 to b56511f Compare September 22, 2024 21:13
@DonIsaac DonIsaac changed the base branch from 09-22-feat_linter_add_unicode_sets_support_to_no-useless-escape_rule to graphite-base/5975 September 22, 2024 21:19
@DonIsaac DonIsaac changed the base branch from graphite-base/5975 to main September 22, 2024 21:23
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 22, 2024
@camchenry camchenry force-pushed the 09-22-test_linter_add_regression_test_for_5227 branch from b56511f to 8b7a902 Compare September 22, 2024 21:26
@camchenry camchenry force-pushed the 09-22-test_linter_add_regression_test_for_5227 branch from 8b7a902 to 9b59328 Compare September 22, 2024 21:29
@camchenry
Copy link
Collaborator Author

apologies for all of the restacks and force pushes, I am still trying to get the hang of Graphite

@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(linter) incorrect fixer for no-useless-escape
3 participants