Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oxc): ban std::collections::HashMap in favor of FxHashMap #5996

Merged

Conversation

camchenry
Copy link
Collaborator

No description provided.

Copy link

graphite-app bot commented Sep 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@camchenry camchenry marked this pull request as ready for review September 23, 2024 15:21
@camchenry camchenry changed the title perf: ban std::collections::HashMap in favor of FxHashMap chore: ban std::collections::HashMap in favor of FxHashMap Sep 23, 2024
@camchenry camchenry marked this pull request as draft September 23, 2024 15:33
@camchenry camchenry force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch from 848792b to 4372a0a Compare September 23, 2024 16:19
@github-actions github-actions bot added the A-ast-tools Area - AST tools label Sep 23, 2024
Copy link

codspeed-hq bot commented Sep 23, 2024

CodSpeed Performance Report

Merging #5996 will not alter performance

Comparing 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ (f14ef7c) with main (c8682e9)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen changed the base branch from 09-23-perf_linter_prettier_diagnostics_use_fxhashmap_instead_of_std_collections_hashmap_ to graphite-base/5996 September 23, 2024 16:29
@Boshen Boshen force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch from 4372a0a to 97e0876 Compare September 23, 2024 16:35
@Boshen Boshen changed the base branch from graphite-base/5996 to main September 23, 2024 16:35
@Boshen Boshen force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch from 97e0876 to 3c97fbf Compare September 23, 2024 16:35
@camchenry camchenry force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch from 3c97fbf to 1f7231c Compare September 23, 2024 17:09
@camchenry camchenry changed the base branch from main to 09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_ September 23, 2024 17:09
@camchenry camchenry force-pushed the 09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_ branch 2 times, most recently from 1bc3c61 to 17ee041 Compare September 23, 2024 17:16
@camchenry camchenry force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch from 1f7231c to 95a5ea0 Compare September 23, 2024 17:16
@camchenry camchenry force-pushed the 09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_ branch from 17ee041 to fe42425 Compare September 23, 2024 17:23
@camchenry camchenry force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch from 95a5ea0 to d6b8d65 Compare September 23, 2024 17:23
@camchenry camchenry changed the title chore: ban std::collections::HashMap in favor of FxHashMap chore(oxc): ban std::collections::HashMap in favor of FxHashMap Sep 23, 2024
@camchenry camchenry marked this pull request as ready for review September 23, 2024 17:25
@camchenry camchenry force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch 2 times, most recently from d466e20 to e14e488 Compare September 23, 2024 17:32
@overlookmotel overlookmotel changed the base branch from 09-23-perf_tasks_use_fxhashmap_over_std_collections_hashmap_ to graphite-base/5996 September 23, 2024 18:28
@overlookmotel overlookmotel force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch from e14e488 to c264de3 Compare September 23, 2024 18:34
@overlookmotel overlookmotel changed the base branch from graphite-base/5996 to main September 23, 2024 18:35
@overlookmotel overlookmotel force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch from c264de3 to 637c563 Compare September 23, 2024 18:35
@camchenry camchenry force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch 2 times, most recently from 7f6cee0 to d32b8da Compare September 23, 2024 22:37
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 24, 2024
Copy link

graphite-app bot commented Sep 24, 2024

Merge activity

  • Sep 24, 1:08 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 24, 1:08 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 24, 1:13 AM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (All comments must be resolved before merging).

@Boshen Boshen force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch from d32b8da to ce768f8 Compare September 24, 2024 05:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 24, 2024
@Boshen
Copy link
Member

Boshen commented Sep 24, 2024

Where's the unresolved conversation?

@Boshen Boshen force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch from ce768f8 to f14ef7c Compare September 24, 2024 08:37
@Boshen Boshen removed the request for review from overlookmotel September 24, 2024 08:37
@Boshen Boshen merged commit 0c9dee1 into main Sep 24, 2024
24 checks passed
@Boshen Boshen deleted the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch September 24, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast-tools Area - AST tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants