Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer): add SparseStack::with_capacity method #6094

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Sep 26, 2024

Add SparseStack::with_capacity method.

Copy link

graphite-app bot commented Sep 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Sep 26, 2024
@overlookmotel overlookmotel marked this pull request as ready for review September 26, 2024 23:31
Copy link

codspeed-hq bot commented Sep 26, 2024

CodSpeed Performance Report

Merging #6094 will not alter performance

Comparing 09-24-refactor_transformer_add_sparsestack_with_capacity_method (e60ce50) with main (bd8f786)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 09-24-perf_transformer_introduce_stack_ branch from 30f3394 to c98b3bb Compare September 26, 2024 23:53
@overlookmotel overlookmotel force-pushed the 09-24-refactor_transformer_add_sparsestack_with_capacity_method branch from cba6534 to e1a6472 Compare September 26, 2024 23:53
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Sep 27, 2024 — with Graphite App
Copy link

graphite-app bot commented Sep 27, 2024

Merge activity

@Dunqing Dunqing force-pushed the 09-24-perf_transformer_introduce_stack_ branch from c98b3bb to 85aff19 Compare September 27, 2024 04:31
@Dunqing Dunqing force-pushed the 09-24-refactor_transformer_add_sparsestack_with_capacity_method branch from e1a6472 to e60ce50 Compare September 27, 2024 04:31
Base automatically changed from 09-24-perf_transformer_introduce_stack_ to main September 27, 2024 04:42
@graphite-app graphite-app bot merged commit e60ce50 into main Sep 27, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 09-24-refactor_transformer_add_sparsestack_with_capacity_method branch September 27, 2024 04:44
Boshen added a commit that referenced this pull request Sep 27, 2024
## [0.30.2] - 2024-09-27

### Features

- 60c52ba ast: Allow passing span to `void_0` method (#6065) (Dunqing)
- cca433f codegen: Print `vite` / `webpack` special comments (#6021)
(Dunqing)
- 8d026e1 regular_expression: Implement `GetSpan` for RegExp AST nodes
(#6056) (camchenry)
- 7764793 regular_expression: Implement visitor pattern trait for regex
AST (#6055) (camchenry)
- f866781 semantic: Check for type annotations on left side of `for..in`
and `for..of` iterators (#6043) (DonIsaac)
- 8b2e9aa semantic: Check for JSDoc types in TS type annotations (#6042)
(DonIsaac)
- 28da771 transformer: Do not transform `**` with bigint literals
(#6023) (Boshen)

### Bug Fixes

- a88504c diagnostics: Check for terminal when displaying links (#6018)
(Boshen)
- 418ae25 isolated-declarations: Report uninferrable types in arrays
(#6084) (michaelm)
- e0a8959 minifier: Compute `void number` as `undefined` (#6028)
(Boshen)
- 0658576 paresr: Do not report missing initializer error in ambient
context (#6020) (Boshen)
- b1af73d semantic: Do not create a `global` symbol for `declare global
{}` (#6040) (DonIsaac)
- c8682e9 semantic,codegen,transformer: Handle definite `!` operator in
variable declarator (#6019) (Boshen)

### Performance

- 6b7d3ed isolated-declarations: Should clone transformed AST rather
than original AST (#6078) (Dunqing)
- 85aff19 transformer: Introduce `Stack` (#6093) (overlookmotel)
- ad4ef31 transformer: Introduce `NonEmptyStack` (#6092) (overlookmotel)

### Documentation

- 3099709 allocator: Document `oxc_allocator` crate (#6037) (DonIsaac)
- d60ceb4 oxc: Add README.md and crate-level docs (#6035) (DonIsaac)
- efabfc8 semantic: Improve doc comments on `Reference` methods (#6076)
(overlookmotel)

### Refactor

- 1fc80d1 ast: Move all ts ast related impl methods to `ast_impl`
(#6015) (Dunqing)
- fe696f0 codegen: Simplify printing annotation comments (#6027)
(Dunqing)
- e60ce50 transformer: Add `SparseStack::with_capacity` method (#6094)
(overlookmotel)
- 1399d2c transformer: Move `SparseStack` definition into folder (#6091)
(overlookmotel)
- 6bd29dd transformer: Add more debug assertions (#6090) (overlookmotel)
- c90b9bf transformer: Rename `SparseStack` methods (#6089)
(overlookmotel)
- 2b380c8 transformer: Remove unsued `self.ctx` (#6022) (Boshen)

### Testing

- 93575cd semantic: Add comprehensive regression test suite (#5976)
(DonIsaac)
- a4cec75 transformer: Enable tests (#6032) (overlookmotel)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants