Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(minifier): minifier benchmark measure only the minifier itself #6222

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 1, 2024

Minifier benchmark currently includes the time to run parser and semantic as well as the minifier itself. Similar to transformer benchmark, only measure the minifier itself in the benchmark.

This will give us a clearer picture of performance changes, and should also reduce variance in the benchmarks.

Copy link

graphite-app bot commented Oct 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel marked this pull request as ready for review October 1, 2024 13:03
@overlookmotel overlookmotel force-pushed the 10-01-ci_minifier_minifier_benchmark_measure_only_the_minifier_itself branch from ce9d45e to 7b8aaaf Compare October 1, 2024 13:18
Copy link

codspeed-hq bot commented Oct 1, 2024

CodSpeed Performance Report

Merging #6222 will improve performances by ×2.1

Comparing 10-01-ci_minifier_minifier_benchmark_measure_only_the_minifier_itself (911e4e5) with main (4b42047)

Summary

⚡ 3 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main 10-01-ci_minifier_minifier_benchmark_measure_only_the_minifier_itself Change
minifier[antd.js] 582.8 ms 346.2 ms +68.35%
minifier[react.development.js] 5.1 ms 2.4 ms ×2.1
minifier[typescript.js] 878.1 ms 448 ms +96.01%

@overlookmotel overlookmotel marked this pull request as draft October 1, 2024 13:29
@overlookmotel overlookmotel force-pushed the 10-01-ci_minifier_minifier_benchmark_measure_only_the_minifier_itself branch from 7b8aaaf to 578f532 Compare October 1, 2024 13:30
@overlookmotel overlookmotel marked this pull request as ready for review October 1, 2024 17:42
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 1, 2024
Copy link

graphite-app bot commented Oct 1, 2024

Merge activity

  • Oct 1, 1:43 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 1, 1:43 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Oct 1, 1:51 PM EDT: overlookmotel merged this pull request with the Graphite merge queue.

)

Minifier benchmark currently includes the time to run parser and semantic as well as the minifier itself. Similar to transformer benchmark, only measure the minifier itself in the benchmark.

This will give us a clearer picture of performance changes, and should also reduce variance in the benchmarks.
@overlookmotel overlookmotel force-pushed the 10-01-ci_minifier_minifier_benchmark_measure_only_the_minifier_itself branch from 578f532 to 911e4e5 Compare October 1, 2024 17:43
@graphite-app graphite-app bot merged commit 911e4e5 into main Oct 1, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-01-ci_minifier_minifier_benchmark_measure_only_the_minifier_itself branch October 1, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants