perf(linter): get fewer parent nodes in unicorn/prefer-dom-node-text-content

[camchenry]

Profiling showed that this rule was one of the slower ones, partially due to the fact that it was constantly calling ctx.nodes() and ctx.nodes().parent_node(). I've tried to fix this by reordering the logic so that we only fetch the parent nodes right before we need it. If we can early return, such as the identifier name not being innerText, or the node kind not being right, then we can skip fetching the parent.

Before:

After (-0.4% reduction in number of samples spent in this rule):

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[camchenry]

• perf(linter): get fewer parent nodes in unicorn/prefer-dom-node-text-content #6467 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #6467 will not alter performance

_{Comparing 10-12-perf_linter_get_fewer_parent_nodes_in_unicorn_prefer-dom-node-text-content_ (725f9f6) with main (6d041fb)}

Summary

✅ 29 untouched benchmarks

[Boshen]

Merge activity

• Oct 13, 10:16 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 13, 10:16 AM EDT: A user added this pull request to the Graphite merge queue.
• Oct 13, 10:21 AM EDT: A user merged this pull request with the Graphite merge queue.