Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast): add GetAddress trait #6652

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 18, 2024

part of #6641

Copy link

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Oct 18, 2024

Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #6652 will not alter performance

Comparing 10-18-feat_ast_add_getaddress_trait (b2f3040) with main (f8e1907)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel self-requested a review October 18, 2024 10:10
Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be preferable for GetAddress trait to be defined in oxc_allocator. But we can move it in a follow-up.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 21, 2024 10:43
Copy link
Contributor

overlookmotel commented Oct 21, 2024

Merge activity

  • Oct 21, 6:44 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 21, 6:45 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 21, 6:50 AM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 10-18-feat_ast_add_getaddress_trait branch from 98d0f5f to b2f3040 Compare October 21, 2024 10:45
@graphite-app graphite-app bot merged commit b2f3040 into main Oct 21, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-18-feat_ast_add_getaddress_trait branch October 21, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants