-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast_tools): use double quotes in TS type defs #6681
refactor(ast_tools): use double quotes in TS type defs #6681
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
fcd9609
to
9068a23
Compare
6205d3a
to
9ca8f75
Compare
CodSpeed Performance ReportMerging #6681 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care about this? It makes the generated code harder to read and longer, plus we're not going to be using wasm-bindgen for this forever.
9068a23
to
85e69a1
Compare
9ca8f75
to
01b9e83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I approved this by mistake, meant to approve #6685
Fair point! |
Follow-on after #6404. Use double quotes in TS type defs, to match the code style
wasm_bindgen
uses for the types it generates.