-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): correct false positive in no-duplicates
#6748
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
no-duplicates
CodSpeed Performance ReportMerging #6748 will not alter performanceComparing Summary
|
I just upgraded to oxlint 0.10.2 and this seems to have broken things for me, unless I misunderstand the rule. I have a huge number of reported breaks in my project now, like:
My full import declaration for that file is: import { QueryResult, useQuery } from "@apollo/client";
import {
AccountRight,
GetAccountDocument,
GetAccountQuery,
GetAccountQueryVariables,
GrantRole,
} from "@app/graphql-codegen";
import { notEmpty } from "@app/utils";
import { Context } from "react";
import { useHistory } from "react-router-dom"; Downgrading to 0.10.0 (but not 0.10.1) causes the errors to disappear. |
## [0.10.3] - 2024-10-26 - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (#6847) (leaysgur) - 8032813 regular_expression: [**BREAKING**] Migrate to new regexp parser API (#6741) (leaysgur) ### Features - a73c5af linter: Add fixer for `jsx-a11y/no-access-key` rule (#6781) (Tapan Prakash) - 2aa763c linter: Warn unmatched rule names (#6782) (Tapan Prakash) - 0acca58 linter: Support `--print-config all` to print config file for project (#6579) (mysteryven) ### Bug Fixes - f49b3e2 linter: `react/iframe-missing-sandbox` ignores vanilla JS APIs (#6872) (DonIsaac) - 54a5032 linter: Correct false positive in `no-duplicates` (#6748) (dalaoshu) - a47c70e minifier: Fix remaining runtime bugs (#6855) (Boshen) ### Documentation - 3923e63 linter: Add schema to config examples (#6838) (Dmitry Zakharov) ### Refactor - a148023 linter: Dereference IDs as soon as possible (#6821) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (#6860) (Boshen) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
## [0.10.3] - 2024-10-26 - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (oxc-project#6847) (leaysgur) - 8032813 regular_expression: [**BREAKING**] Migrate to new regexp parser API (oxc-project#6741) (leaysgur) ### Features - a73c5af linter: Add fixer for `jsx-a11y/no-access-key` rule (oxc-project#6781) (Tapan Prakash) - 2aa763c linter: Warn unmatched rule names (oxc-project#6782) (Tapan Prakash) - 0acca58 linter: Support `--print-config all` to print config file for project (oxc-project#6579) (mysteryven) ### Bug Fixes - f49b3e2 linter: `react/iframe-missing-sandbox` ignores vanilla JS APIs (oxc-project#6872) (DonIsaac) - 54a5032 linter: Correct false positive in `no-duplicates` (oxc-project#6748) (dalaoshu) - a47c70e minifier: Fix remaining runtime bugs (oxc-project#6855) (Boshen) ### Documentation - 3923e63 linter: Add schema to config examples (oxc-project#6838) (Dmitry Zakharov) ### Refactor - a148023 linter: Dereference IDs as soon as possible (oxc-project#6821) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (oxc-project#6860) (Boshen) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
closes #6736
There may be a better solution. If there is a good way to fix it, please feel free to close it. I will fix the clippy problem later because I went back to the dormitory to sleep and my computer was in the studio.