refactor(ast_tools): TypeDef::name return a &str
#6776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
This was referenced Oct 22, 2024
github-actions
bot
added
the
C-cleanup
Merge activity
|
Boshen
force-pushed
the
10-22-refactor_ast_tools_shorter_code_in_astkindgenerator_
branch
from
e167a03 to
bf035d1
Compare
Boshen
pushed a commit
that referenced
this pull request
Oct 22, 2024
It's generally an anti-pattern for functions to return `&String`. `&str` is preferable.
Boshen
force-pushed
the
10-22-refactor_ast_tools_typedef_name_return_a_str_
branch
from
ea2b440 to
d1f9938
Compare
It's generally an anti-pattern for functions to return `&String`. `&str` is preferable.
Boshen
force-pushed
the
10-22-refactor_ast_tools_shorter_code_in_astkindgenerator_
branch
from
bf035d1 to
09d2df1
Compare
Boshen
force-pushed
the
10-22-refactor_ast_tools_typedef_name_return_a_str_
branch
from
d1f9938 to
d2b8f50
Compare
Base automatically changed from
10-22-refactor_ast_tools_shorter_code_in_astkindgenerator_
to
main
October 22, 2024 12:25
graphite-app
bot
deleted the
10-22-refactor_ast_tools_typedef_name_return_a_str_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's generally an anti-pattern for functions to return
&String.&stris preferable.