feat(traverse): implement `GetAddress` for `Ancestor` #6877

overlookmotel · 2024-10-24T20:29:36Z

Closes #6803. Allow getting Address of an Ancestor.

graphite-app · 2024-10-24T20:29:41Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

overlookmotel · 2024-10-24T20:29:52Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

codspeed-hq · 2024-10-24T20:36:13Z

CodSpeed Performance Report

Merging #6877 will not alter performance

_{Comparing 10-24-feat_traverse_implement_getaddress_for_ancestor_ (419343b) with main (1f29523)}

Summary

✅ 30 untouched benchmarks

Dunqing · 2024-10-25T01:45:19Z

Let me try this to get #6803 (comment) case done

Dunqing · 2024-10-25T07:31:32Z

I just found out we need to revert #6858 or change it to accept a param that has implemented GetAddress trait

overlookmotel · 2024-10-25T08:49:20Z

I just found out we need to revert #6858 or change it to accept a param that has implemented GetAddress trait

Ah yes of course. I suggest we do the 2nd - broaden StatementInjectorStore's methods to accept any &A where A: GetAddress.

I think this PR can be merged in meantime? If we find problems with it, we can always make changes/revert.

Dunqing · 2024-10-25T10:36:02Z

Ah yes of course. I suggest we do the 2nd - broaden StatementInjectorStore's methods to accept any &A where A: GetAddress.

I think this PR can be merged in meantime? If we find problems with it, we can always make changes/revert.

Yes, we can!

Dunqing

LGTM

overlookmotel · 2024-10-25T10:51:33Z

Merge activity

Oct 25, 6:51 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 25, 6:51 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 25, 6:56 AM EDT: A user merged this pull request with the Graphite merge queue.

Closes #6803. Allow getting `Address` of an `Ancestor`.

## [0.34.0] - 2024-10-26 - 4618aa2 transformer: [**BREAKING**] Rename `TransformerOptions::react` to `jsx` (#6888) (Boshen) - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (#6847) (leaysgur) - 67a7bde napi/parser: [**BREAKING**] Add typings to napi/parser (#6796) (ottomated) ### Features - 1145341 ast_tools: Output typescript to a separate package (#6755) (ottomated) - 4429754 ecmascript: Constant eval `null` to number (#6879) (Boshen) - fd57e00 ecmascript: Add abstract_relational_comparison to dce (#6846) (Boshen) - 8bcaf59 minifier: Late peeophole optimization (#6882) (Boshen) - 860cbca minifier: Implement folding simple arrow fns (#6875) (camc314) - c26020e minifier: Implement folding String.prototype.replaceAll (#6871) (camc314) - 50744f3 minifier: Implement folding String.prototype.replace (#6870) (camc314) - fccf82e minifier: Implement folding `substring` string fns (#6869) (camc314) - e6a5a1b minifier: Implement folding `charCodeAt` string fns (#6475) (camc314) - 0d0bb17 transformer: Complete the async-to-generator plugin (#6658) (Dunqing) - 419343b traverse: Implement `GetAddress` for `Ancestor` (#6877) (overlookmotel) ### Bug Fixes - a47c70e minifier: Fix remaining runtime bugs (#6855) (Boshen) - 686727f minifier: Reference read has side effect (#6851) (Boshen) - c658d93 minifier: Keep template literals with expressions (#6849) (Boshen) - 4dc5e51 transformer: Only run typescript plugin for typescript source (#6889) (Boshen) - 076f5c3 transformer/typescript: Retain ExportNamedDeclaration without specifiers and declaration (#6848) (Dunqing) - b075982 types: Change @oxc/types package name (#6874) (ottomated) ### Documentation - 6eeb0e6 ast: Mention typescript-eslint, field ordering and shape (#6863) (Boshen) - 99e3b32 napi: Remove JSON.parse from example (#6836) (ottomated) ### Refactor - adb5039 allocator: Add `impl GetAddress for Address` (#6891) (overlookmotel) - 3e7507f ast_tools: Reduce macro usage (#6895) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (#6860) (Boshen) - 2d95009 transformer: Implement `Debug` on `StatementInjector` internal types (#6886) (overlookmotel) - c383c34 transformer: Make `StatementInjectorStore` methods generic over `GetAddress` (#6885) (overlookmotel) - 1f29523 transformer: Rename ReactJsx to Jsx (#6883) (Boshen) - 333b758 transformer: `StatementInjectorStore` methods take `&Statement` as target (#6858) (overlookmotel) - c19996c transformer: Add `StatementInjectorStore::insert_many_before` method (#6857) (overlookmotel) - 7339dde transformer: `StatementInjectorStore::insert_many_after` take an iterator (#6856) (overlookmotel) - 4348eae transformer/typescript: Re-order visitor methods (#6864) (overlookmotel) - 3a56d59 transformer/typescript: Insert assignments after super by `StatementInjector` (#6654) (Dunqing) - a366fae traverse: Rename `TraverseScoping::generate_binding_in_current_scope` (#6832) (overlookmotel) - 3b99fe6 traverse: Move `generate_binding` to `TraverseScoping` (#6831) (overlookmotel) - 60f487a traverse: `TraverseCtx::generate_binding` take an `Atom` (#6830) (overlookmotel) ### Styling - 262b2ed ast: Move crate doc comment to top of file (#6890) (overlookmotel) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Closes oxc-project#6803. Allow getting `Address` of an `Ancestor`.

## [0.34.0] - 2024-10-26 - 4618aa2 transformer: [**BREAKING**] Rename `TransformerOptions::react` to `jsx` (oxc-project#6888) (Boshen) - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (oxc-project#6847) (leaysgur) - 67a7bde napi/parser: [**BREAKING**] Add typings to napi/parser (oxc-project#6796) (ottomated) ### Features - 1145341 ast_tools: Output typescript to a separate package (oxc-project#6755) (ottomated) - 4429754 ecmascript: Constant eval `null` to number (oxc-project#6879) (Boshen) - fd57e00 ecmascript: Add abstract_relational_comparison to dce (oxc-project#6846) (Boshen) - 8bcaf59 minifier: Late peeophole optimization (oxc-project#6882) (Boshen) - 860cbca minifier: Implement folding simple arrow fns (oxc-project#6875) (camc314) - c26020e minifier: Implement folding String.prototype.replaceAll (oxc-project#6871) (camc314) - 50744f3 minifier: Implement folding String.prototype.replace (oxc-project#6870) (camc314) - fccf82e minifier: Implement folding `substring` string fns (oxc-project#6869) (camc314) - e6a5a1b minifier: Implement folding `charCodeAt` string fns (oxc-project#6475) (camc314) - 0d0bb17 transformer: Complete the async-to-generator plugin (oxc-project#6658) (Dunqing) - 419343b traverse: Implement `GetAddress` for `Ancestor` (oxc-project#6877) (overlookmotel) ### Bug Fixes - a47c70e minifier: Fix remaining runtime bugs (oxc-project#6855) (Boshen) - 686727f minifier: Reference read has side effect (oxc-project#6851) (Boshen) - c658d93 minifier: Keep template literals with expressions (oxc-project#6849) (Boshen) - 4dc5e51 transformer: Only run typescript plugin for typescript source (oxc-project#6889) (Boshen) - 076f5c3 transformer/typescript: Retain ExportNamedDeclaration without specifiers and declaration (oxc-project#6848) (Dunqing) - b075982 types: Change @oxc/types package name (oxc-project#6874) (ottomated) ### Documentation - 6eeb0e6 ast: Mention typescript-eslint, field ordering and shape (oxc-project#6863) (Boshen) - 99e3b32 napi: Remove JSON.parse from example (oxc-project#6836) (ottomated) ### Refactor - adb5039 allocator: Add `impl GetAddress for Address` (oxc-project#6891) (overlookmotel) - 3e7507f ast_tools: Reduce macro usage (oxc-project#6895) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (oxc-project#6860) (Boshen) - 2d95009 transformer: Implement `Debug` on `StatementInjector` internal types (oxc-project#6886) (overlookmotel) - c383c34 transformer: Make `StatementInjectorStore` methods generic over `GetAddress` (oxc-project#6885) (overlookmotel) - 1f29523 transformer: Rename ReactJsx to Jsx (oxc-project#6883) (Boshen) - 333b758 transformer: `StatementInjectorStore` methods take `&Statement` as target (oxc-project#6858) (overlookmotel) - c19996c transformer: Add `StatementInjectorStore::insert_many_before` method (oxc-project#6857) (overlookmotel) - 7339dde transformer: `StatementInjectorStore::insert_many_after` take an iterator (oxc-project#6856) (overlookmotel) - 4348eae transformer/typescript: Re-order visitor methods (oxc-project#6864) (overlookmotel) - 3a56d59 transformer/typescript: Insert assignments after super by `StatementInjector` (oxc-project#6654) (Dunqing) - a366fae traverse: Rename `TraverseScoping::generate_binding_in_current_scope` (oxc-project#6832) (overlookmotel) - 3b99fe6 traverse: Move `generate_binding` to `TraverseScoping` (oxc-project#6831) (overlookmotel) - 60f487a traverse: `TraverseCtx::generate_binding` take an `Atom` (oxc-project#6830) (overlookmotel) ### Styling - 262b2ed ast: Move crate doc comment to top of file (oxc-project#6890) (overlookmotel) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

github-actions bot added the C-enhancement Category - New feature or request label Oct 24, 2024

overlookmotel marked this pull request as ready for review October 24, 2024 20:31

overlookmotel requested a review from Dunqing October 24, 2024 20:31

This was referenced Oct 25, 2024

refactor(transformer/react-refresh): use StatementInjector to insert statements #6881

Merged

refactor(transformer/react-refresh): use VarDeclarations to insert declarators #6884

Merged

Dunqing approved these changes Oct 25, 2024

View reviewed changes

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 25, 2024

feat(traverse): implement GetAddress for Ancestor (#6877)

419343b

Closes #6803. Allow getting `Address` of an `Ancestor`.

overlookmotel force-pushed the 10-24-feat_traverse_implement_getaddress_for_ancestor_ branch from 6e48978 to 419343b Compare October 25, 2024 10:52

graphite-app bot merged commit 419343b into main Oct 25, 2024
27 checks passed

graphite-app bot deleted the 10-24-feat_traverse_implement_getaddress_for_ancestor_ branch October 25, 2024 10:56

overlookmotel mentioned this pull request Oct 25, 2024

traverse: provide an API to get the address of Ancestor #6803

Closed

oxc-bot mentioned this pull request Oct 26, 2024

release(crates): v0.34.0 #6908

Merged

Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024

feat(traverse): implement GetAddress for Ancestor (oxc-project#6877)

3cb0adc

Closes oxc-project#6803. Allow getting `Address` of an `Ancestor`.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(traverse): implement `GetAddress` for `Ancestor` #6877

feat(traverse): implement `GetAddress` for `Ancestor` #6877

overlookmotel commented Oct 24, 2024 •

edited

Loading

graphite-app bot commented Oct 24, 2024

overlookmotel commented Oct 24, 2024 •

edited by Dunqing

Loading

codspeed-hq bot commented Oct 24, 2024 •

edited

Loading

Dunqing commented Oct 25, 2024

Dunqing commented Oct 25, 2024 •

edited

Loading

overlookmotel commented Oct 25, 2024

Dunqing commented Oct 25, 2024

Dunqing left a comment

overlookmotel commented Oct 25, 2024 •

edited by graphite-app bot

Loading

feat(traverse): implement GetAddress for Ancestor #6877

feat(traverse): implement GetAddress for Ancestor #6877

Conversation

overlookmotel commented Oct 24, 2024 • edited Loading

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

overlookmotel commented Oct 24, 2024 • edited by Dunqing Loading

codspeed-hq bot commented Oct 24, 2024 • edited Loading

CodSpeed Performance Report

Merging #6877 will not alter performance

Summary

Dunqing commented Oct 25, 2024

Dunqing commented Oct 25, 2024 • edited Loading

overlookmotel commented Oct 25, 2024

Dunqing commented Oct 25, 2024

Dunqing left a comment

Choose a reason for hiding this comment

overlookmotel commented Oct 25, 2024 • edited by graphite-app bot Loading

Merge activity

feat(traverse): implement `GetAddress` for `Ancestor` #6877

feat(traverse): implement `GetAddress` for `Ancestor` #6877

overlookmotel commented Oct 24, 2024 •

edited

Loading

overlookmotel commented Oct 24, 2024 •

edited by Dunqing

Loading

codspeed-hq bot commented Oct 24, 2024 •

edited

Loading

Dunqing commented Oct 25, 2024 •

edited

Loading

overlookmotel commented Oct 25, 2024 •

edited by graphite-app bot

Loading