Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): move LintPlugins from LintOptions to LintConfig #6932

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Oct 26, 2024

Pure refactor. Moves plugin settings from linter options (which control the linter's behavior on a global level) and linter config ("which may or may not get adjusted on each file).

Copy link

graphite-app bot commented Oct 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 26, 2024
Copy link
Contributor Author

DonIsaac commented Oct 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Oct 26, 2024

CodSpeed Performance Report

Merging #6932 will not alter performance

Comparing don/10-26-refactor_linter_move_lintplugins_from_lintoptions_to_lintconfig_ (8f1460e) with main (1691cab)

Summary

✅ 30 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/10-26-refactor_linter_move_lintplugins_from_lintoptions_to_lintconfig_ branch 4 times, most recently from 9227ffc to 4c1f24b Compare October 28, 2024 01:31
@DonIsaac DonIsaac requested a review from camchenry October 28, 2024 02:35
@DonIsaac DonIsaac marked this pull request as ready for review October 28, 2024 02:35
@DonIsaac DonIsaac force-pushed the don/10-26-refactor_linter_move_lintplugins_from_lintoptions_to_lintconfig_ branch 2 times, most recently from f6a7fbb to 0be2975 Compare October 28, 2024 17:41
@DonIsaac DonIsaac requested review from Boshen and camc314 October 28, 2024 17:51
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 29, 2024
Copy link
Member

Boshen commented Oct 29, 2024

Merge activity

  • Oct 28, 9:27 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 28, 9:27 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 28, 9:32 PM EDT: A user merged this pull request with the Graphite merge queue.

…g` (#6932)

Pure refactor. Moves plugin settings from linter options (which control the linter's behavior on a global level) and linter config ("which may or may not get adjusted on each file).
@Boshen Boshen force-pushed the don/10-26-refactor_linter_move_lintplugins_from_lintoptions_to_lintconfig_ branch from 0be2975 to 8f1460e Compare October 29, 2024 01:28
@graphite-app graphite-app bot merged commit 8f1460e into main Oct 29, 2024
26 checks passed
@graphite-app graphite-app bot deleted the don/10-26-refactor_linter_move_lintplugins_from_lintoptions_to_lintconfig_ branch October 29, 2024 01:32
@oxc-bot oxc-bot mentioned this pull request Nov 3, 2024
Boshen added a commit that referenced this pull request Nov 3, 2024
## [0.11.0] - 2024-11-03

- 9fd9f4f linter: [**BREAKING**] Sync sindresorhus/globals; removed
Object.prototype properties from builtin and es* globals (#6991)
(Boshen)

### Features

- 6b619da editor: Listen to config file changes and trigger a
didChangeConfiguration update (#6964) (Nicholas Rayburn)
- 7872927 editor/vscode: Support window/showMessage event (#7085)
(Nicholas Rayburn)
- 2184588 linter: Do not bail for unmatched rules yet (#7093) (Boshen)
- a6fcd81 linter: Add `import/no-commonjs` rule (#6978) (Dmitry
Zakharov)
- 1691cab linter: Support user-configurable secrets for
`oxc-security/api-keys` (#5938) (DonIsaac)
- 610621c linter: Implement `react/style-prop-object` (#6342) (Albert
Kaaman)
- 1e2f012 linter: Add `oxc/no-map-spread` (#6751) (DonIsaac)
- 1c66473 linter: Implement `eslint/prefer-object-has-own` (#6905)
(tomoya yanagibashi)

### Bug Fixes

- ebf3753 editor: Fix onConfigChange to send the correct config for
didChangeConfiguration notification (#6962) (Nicholas Rayburn)
- 79bf74a linter: Check is_reference_to_global_variable in
`no-array-constructor` (#7067) (Naoya Yoshizawa)
- 38d1f78 linter: Remove confusing help text for now (#7081) (Cam
McHenry)
- 147e2e4 linter: Allow replacing rule when none are enabled yet (#7014)
(camchenry)
- 7aa496a linter: Remove unsafe fixer of `no-useless-spread` (#6655)
(dalaoshu)
- f5a7134 linter/no-unused-vars: False positive for discarded reads
within sequences (#6907) (DonIsaac)

### Documentation

- 4551baa linter: Document `rules` (#6983) (Boshen)

### Refactor

- a8dc75d linter: Remove unused CLI result types (#7088) (camchenry)
- 8f1460e linter: Move `LintPlugins` from `LintOptions` to `LintConfig`
(#6932) (DonIsaac)

### Testing

- c35d3f2 linter: Improve test failure output (#6975) (camchenry)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants