Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer): transform object rest spread #7003

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Oct 29, 2024

Copy link

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Oct 29, 2024
@Boshen Boshen force-pushed the object-reset-spread branch from aacab9b to 43540b3 Compare October 29, 2024 14:52
@Boshen Boshen requested a review from Dunqing November 4, 2024 10:16
@Boshen Boshen force-pushed the object-reset-spread branch 2 times, most recently from 13841ca to a9a0d7f Compare November 11, 2024 14:32
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #7003 will degrade performances by 9.8%

Comparing object-reset-spread (224775c) with main (b3d5802)

Summary

❌ 4 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main object-reset-spread Change
transformer[antd.js] 45.4 ms 49.5 ms -8.43%
transformer[cal.com.tsx] 33.9 ms 35.5 ms -4.63%
transformer[checker.ts] 18.8 ms 20.8 ms -9.67%
transformer[pdf.mjs] 7 ms 7.8 ms -9.8%

@Boshen Boshen force-pushed the object-reset-spread branch 4 times, most recently from c1e07ab to 4b1dd48 Compare November 13, 2024 09:07
@github-actions github-actions bot added the A-ast Area - AST label Nov 13, 2024
@Boshen Boshen force-pushed the object-reset-spread branch 4 times, most recently from 8474b57 to b182cf4 Compare November 14, 2024 07:58
@Boshen Boshen changed the title feat(transformer): transform BindingRestProperty feat(transformer): transform object rest spread Nov 14, 2024
@Boshen Boshen force-pushed the object-reset-spread branch 12 times, most recently from f29b62d to 79c15c8 Compare November 19, 2024 08:31
@Boshen Boshen force-pushed the object-reset-spread branch from 79c15c8 to eb0654e Compare November 19, 2024 14:44
@Boshen Boshen force-pushed the object-reset-spread branch from eb0654e to a47d829 Compare November 21, 2024 09:02
@Boshen Boshen marked this pull request as ready for review November 21, 2024 11:31
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 21, 2024
Copy link
Member Author

Boshen commented Nov 21, 2024

Merge activity

  • Nov 21, 6:32 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 21, 6:32 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 21, 6:38 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the object-reset-spread branch from 5c765b0 to 224775c Compare November 21, 2024 11:33
@graphite-app graphite-app bot merged commit 224775c into main Nov 21, 2024
27 checks passed
@graphite-app graphite-app bot deleted the object-reset-spread branch November 21, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant