Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ast): correct doc comment for StringLiteral #7255

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 12, 2024

Correct doc comment for StringLiteral's value field. The doc comment was wrong.

Copy link

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation labels Nov 12, 2024
@overlookmotel overlookmotel force-pushed the 11-12-docs_ast_correct_doc_comment_for_stringliteral_ branch from d2cf7ae to 02f82d3 Compare November 12, 2024 13:42
@overlookmotel overlookmotel marked this pull request as ready for review November 12, 2024 13:43
@overlookmotel
Copy link
Contributor Author

Just corrects a comment, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 12, 2024
Copy link
Contributor Author

overlookmotel commented Nov 12, 2024

Merge activity

  • Nov 12, 8:43 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 12, 8:46 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 12, 8:48 AM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason.
  • Nov 12, 8:48 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 12, 8:52 AM EST: A user added this pull request to the Graphite merge queue.

Correct doc comment for `StringLiteral`'s `value` field. The doc comment was wrong.
@overlookmotel overlookmotel force-pushed the 11-12-docs_ast_correct_doc_comment_for_stringliteral_ branch from 02f82d3 to 740ba4b Compare November 12, 2024 13:47
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Nov 12, 2024
@graphite-app graphite-app bot merged commit 740ba4b into main Nov 12, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-12-docs_ast_correct_doc_comment_for_stringliteral_ branch November 12, 2024 13:52
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #7255 will not alter performance

Comparing 11-12-docs_ast_correct_doc_comment_for_stringliteral_ (740ba4b) with main (ef847da)

Summary

✅ 30 untouched benchmarks

Dunqing pushed a commit that referenced this pull request Nov 17, 2024
Correct doc comment for `StringLiteral`'s `value` field. The doc comment was wrong.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Correct doc comment for `StringLiteral`'s `value` field. The doc comment was wrong.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Correct doc comment for `StringLiteral`'s `value` field. The doc comment was wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant