Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(traverse): tidy doc comments for TraverseCtx::is_static #7267

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 13, 2024

Better describe what this method does in its doc comment, and tidy up wording a little.

Copy link

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Nov 13, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 13, 2024 11:36
@overlookmotel
Copy link
Contributor Author

Small correction to docs only, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024
Copy link
Contributor Author

overlookmotel commented Nov 13, 2024

Merge activity

  • Nov 13, 6:37 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 13, 6:39 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 13, 6:44 AM EST: A user merged this pull request with the Graphite merge queue.

Better describe what this method does in its doc comment, and tidy up wording a little.
@overlookmotel overlookmotel force-pushed the 11-13-docs_traverse_tidy_doc_comments_for_traversectx_is_static_ branch from 32a7d2e to 834c94d Compare November 13, 2024 11:40
@graphite-app graphite-app bot merged commit 834c94d into main Nov 13, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 11-13-docs_traverse_tidy_doc_comments_for_traversectx_is_static_ branch November 13, 2024 11:44
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #7267 will not alter performance

Comparing 11-13-docs_traverse_tidy_doc_comments_for_traversectx_is_static_ (834c94d) with main (7a48728)

Summary

✅ 30 untouched benchmarks

Dunqing pushed a commit that referenced this pull request Nov 17, 2024
Better describe what this method does in its doc comment, and tidy up wording a little.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Better describe what this method does in its doc comment, and tidy up wording a little.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Better describe what this method does in its doc comment, and tidy up wording a little.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-docs Category - Documentation. Related to user-facing or internal documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant