perf(transformer/arrow-function): create super method binding names lazily #7313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-transformer
This was referenced Nov 16, 2024
CodSpeed Performance ReportMerging #7313 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
11-16-perf_transformer_arrow-function_super_method_binding_names_lazily
branch
from
0cb33fa to
63a68fd
Compare
overlookmotel
changed the base branch from
11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_
to
11-16-refactor_transformer_arrow-functions_use_indexmap_for_super_getter_setters
overlookmotel
changed the title
overlookmotel
force-pushed
the
11-16-refactor_transformer_arrow-functions_use_indexmap_for_super_getter_setters
branch
from
4c3f93d to
65bd6a8
Compare
overlookmotel
force-pushed
the
11-16-perf_transformer_arrow-function_super_method_binding_names_lazily
branch
from
63a68fd to
94b20ba
Compare
This was referenced Nov 16, 2024
Merge activity
|
Dunqing
force-pushed
the
11-16-refactor_transformer_arrow-functions_use_indexmap_for_super_getter_setters
branch
from
65bd6a8 to
6472077
Compare
Dunqing
pushed a commit
that referenced
this pull request
Nov 17, 2024
…azily (#7313) Key `super` getter/setter hash map with original property name `&str`, instead of generated binding name. This allows a couple of improvements: * Generate binding names for `super` getters/setters lazily, only when they're created, rather than every time you encounter a `super`. * Don't allocate strings into arena which are never used as part of AST. Use `CompactString` for building those strings instead.
Dunqing
force-pushed
the
11-16-perf_transformer_arrow-function_super_method_binding_names_lazily
branch
from
94b20ba to
f1cd977
Compare
overlookmotel
force-pushed
the
11-16-refactor_transformer_arrow-functions_use_indexmap_for_super_getter_setters
branch
from
6472077 to
3555cf9
Compare
overlookmotel
added a commit
that referenced
this pull request
Nov 17, 2024
…azily (#7313) Key `super` getter/setter hash map with original property name `&str`, instead of generated binding name. This allows a couple of improvements: * Generate binding names for `super` getters/setters lazily, only when they're created, rather than every time you encounter a `super`. * Don't allocate strings into arena which are never used as part of AST. Use `CompactString` for building those strings instead.
overlookmotel
force-pushed
the
11-16-perf_transformer_arrow-function_super_method_binding_names_lazily
branch
from
f1cd977 to
1821352
Compare
…azily (#7313) Key `super` getter/setter hash map with original property name `&str`, instead of generated binding name. This allows a couple of improvements: * Generate binding names for `super` getters/setters lazily, only when they're created, rather than every time you encounter a `super`. * Don't allocate strings into arena which are never used as part of AST. Use `CompactString` for building those strings instead.
overlookmotel
force-pushed
the
11-16-refactor_transformer_arrow-functions_use_indexmap_for_super_getter_setters
branch
from
3555cf9 to
5d85386
Compare
overlookmotel
force-pushed
the
11-16-perf_transformer_arrow-function_super_method_binding_names_lazily
branch
from
1821352 to
e09d2df
Compare
Base automatically changed from
11-16-refactor_transformer_arrow-functions_use_indexmap_for_super_getter_setters
to
main
November 17, 2024 10:40
graphite-app
bot
deleted the
11-16-perf_transformer_arrow-function_super_method_binding_names_lazily
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key
supergetter/setter hash map with original property name&str, instead of generated binding name. This allows a couple of improvements:supergetters/setters lazily, only when they're created, rather than every time you encounter asuper.CompactStringfor building those strings instead.