Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(isolated_declarations): do not copy Vec unnecessarily #7332

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 17, 2024

This function receives an owned oxc_allocator::Vec. No need to copy the contents to a new Vec with AstBuilder::vec_from_iter, can just use the original.

Copy link

graphite-app bot commented Nov 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review November 17, 2024 18:54
@github-actions github-actions bot added A-isolated-declarations Isolated Declarations C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 17, 2024
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #7332 will not alter performance

Comparing 11-17-refactor_isolated_declarations_do_not_copy_vec_unnecessarily (1938a1d) with main (44fd962)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 18, 2024
Copy link
Member

Boshen commented Nov 18, 2024

Merge activity

  • Nov 17, 9:28 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 17, 9:28 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 17, 9:33 PM EST: A user merged this pull request with the Graphite merge queue.

This function receives an owned `oxc_allocator::Vec`. No need to copy the contents to a new `Vec` with `AstBuilder::vec_from_iter`, can just use the original.
@Boshen Boshen force-pushed the 11-17-refactor_isolated_declarations_do_not_copy_vec_unnecessarily branch from 9b43c8c to 1938a1d Compare November 18, 2024 02:28
@graphite-app graphite-app bot merged commit 1938a1d into main Nov 18, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-17-refactor_isolated_declarations_do_not_copy_vec_unnecessarily branch November 18, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-isolated-declarations Isolated Declarations C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants