refactor(ast)!: remove impl GetAddress for Function
#7343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-ast
CodSpeed Performance ReportMerging #7343 will not alter performanceComparing Summary
|
Merge activity
|
Boshen
force-pushed
the
11-18-refactor_ast_remove_impl_getaddress_for_function_
branch
from
f4ec21f to
a3b56cb
Compare
Boshen
pushed a commit
that referenced
this pull request
Nov 19, 2024
`impl GetAddress for Function` was added as a hack, in the absence of another way to get the `Address` of a `&Function` (oxc-project/backlog#140). Remove it, and use `Address:from_ptr` instead in JSX Refresh transform, which is only place using it.
`impl GetAddress for Function` was added as a hack, in the absence of another way to get the `Address` of a `&Function` (oxc-project/backlog#140). Remove it, and use `Address:from_ptr` instead in JSX Refresh transform, which is only place using it.
Boshen
force-pushed
the
11-18-refactor_ast_remove_impl_getaddress_for_function_
branch
from
a3b56cb to
41a0e60
Compare
graphite-app
bot
deleted the
11-18-refactor_ast_remove_impl_getaddress_for_function_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl GetAddress for Functionwas added as a hack, in the absence of another way to get theAddressof a&Function(oxc-project/backlog#140).Remove it, and use
Address:from_ptrinstead in JSX Refresh transform, which is only place using it.