Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): hanging when source has syntax/is flow #7432

Merged

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Nov 23, 2024

Closes #7406

See #7406 (comment) for why this is happening

not sure whether there's a better solve for this/

Copy link

graphite-app bot commented Nov 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

camc314 commented Nov 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Nov 23, 2024
@camc314 camc314 marked this pull request as ready for review November 23, 2024 10:43
@camc314 camc314 force-pushed the c/11-23-fix_linter_hanging_when_source_has_syntax_is_flow branch from b2e9a97 to 5ecd0dd Compare November 23, 2024 10:46
@github-actions github-actions bot added the A-cli Area - CLI label Nov 23, 2024
@camc314 camc314 force-pushed the c/11-23-fix_linter_hanging_when_source_has_syntax_is_flow branch from 5ecd0dd to 1708a48 Compare November 23, 2024 10:48
@camc314 camc314 requested review from camchenry and Boshen November 23, 2024 10:48
Copy link

codspeed-hq bot commented Nov 23, 2024

CodSpeed Performance Report

Merging #7432 will not alter performance

Comparing c/11-23-fix_linter_hanging_when_source_has_syntax_is_flow (452d6be) with main (21614f2)

Summary

✅ 30 untouched benchmarks

@camc314 camc314 force-pushed the c/11-23-fix_linter_hanging_when_source_has_syntax_is_flow branch from 1708a48 to 452d6be Compare November 23, 2024 13:15
@Boshen Boshen merged commit 8507464 into main Nov 23, 2024
28 checks passed
@Boshen Boshen deleted the c/11-23-fix_linter_hanging_when_source_has_syntax_is_flow branch November 23, 2024 15:20
Boshen added a commit that referenced this pull request Nov 23, 2024
## [0.13.1] - 2024-11-23

### Features

- 4ad26b9 linter: Add `no-promise-in-callback` (#7307) (no-yan)
- 9558087 oxlint: Auto detect config file in CLI (#7348) (Alexander S.)

### Bug Fixes

- 8507464 linter: Hanging when source has syntax/is flow (#7432)
(Cameron)
- e88cf1b linter: Make `overrides` globs relative to config path (#7407)
(camchenry)
- 9002e97 linter: Add proper support for findIndex and findLastIndex for
`unicorn/prefer-array-some` (#7405) (Dmitry Zakharov)

### Documentation

- 6730e3e linter: Add more examples for `unicorn/prefer-array-some`
(#7411) (Dmitry Zakharov)

### Refactor

- 6c0d31b linter: Remove useless `const` declaration (#7430) (Song Gao)
- c8adc46 linter/no-unused-vars: Improve implementation to remove using
SymbolFlags::Export (#7412) (Dunqing)
- c90537f linter/only-used-in-recursion: Improve implementation to
remove using SymbolFlags::Export (#7413) (Dunqing)

### Testing

- 779f479 editor: Check if workspace configuration is updated (#7403)
(Alexander S.)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: 0.13.0 is hanging with --import-plugin (or taking more than 5 minutes)
2 participants