Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add idempotence test to --fix #19

Closed
Boshen opened this issue Jul 10, 2024 · 0 comments
Closed

Add idempotence test to --fix #19

Boshen opened this issue Jul 10, 2024 · 0 comments
Assignees
@DonIsaac

Comments

@Boshen
Copy link
Member

Boshen commented Jul 10, 2024 •
edited
Loading

run fix, then run fix again on the fixed code, the result should be the same.
@DonIsaac DonIsaac self-assigned this Jul 10, 2024
DonIsaac added a commit that referenced this issue Jul 10, 2024
@DonIsaac
feat: re-parse after running --fix
af8b62a 
Related to, but does not fully address, #19.

> NOTE: this PR also enables the vitest plugin

Adds a step to the test stage that re-runs oxlint after it was previously run
with `--fix`. This should help us catch syntax errors created by buggy fixes.

We should also consider running `typecheck` scripts for repositories that have
them.
This was referenced Jul 10, 2024
Closed
Closed
@Boshen Boshen mentioned this issue Aug 23, 2024
Closed
@Boshen Boshen closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DonIsaac DonIsaac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: check broken code fixes oxc-project/oxlint-ecosystem-ci
2 participants
@Boshen @DonIsaac