Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint reduction for inequalities with infinite RHS #115

Merged
merged 17 commits into from
Mar 4, 2023

Conversation

goulart-paul
Copy link
Member

Implements a very basic constraint reduction mechanism to remove constraints in nonnegative cones with infinite RHSs, where "Clarabel.INFINITY" is a settable parameter at module level.

Fixes #85.
Prototype of fix for oxfordcontrol/Clarabel.rs#14

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Patch coverage: 96.19% and project coverage change: +0.59 🎉

Comparison is base (50b0c6e) 82.22% compared to head (875b182) 82.82%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff               @@
##           dev/v0.5.0     #115      +/-   ##
==============================================
+ Coverage       82.22%   82.82%   +0.59%     
==============================================
  Files              37       38       +1     
  Lines            2701     2730      +29     
==============================================
+ Hits             2221     2261      +40     
+ Misses            480      469      -11     
Impacted Files Coverage Δ
src/settings.jl 8.00% <ø> (ø)
src/variables.jl 77.64% <ø> (+11.64%) ⬆️
src/presolver.jl 88.23% <88.23%> (ø)
src/Clarabel.jl 100.00% <100.00%> (ø)
src/cones/compositecone_type.jl 94.59% <100.00%> (-0.28%) ⬇️
src/cones/cone_types.jl 93.44% <100.00%> (ø)
src/cones/coneops_compositecone.jl 87.64% <100.00%> (ø)
src/cones/coneops_nncone.jl 82.08% <100.00%> (+0.55%) ⬆️
src/info_print.jl 96.90% <100.00%> (+0.06%) ⬆️
src/kktsolvers/direct-ldl/directldl_utils.jl 88.78% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@goulart-paul goulart-paul merged commit e219c43 into dev/v0.5.0 Mar 4, 2023
goulart-paul added a commit that referenced this pull request Mar 8, 2023
* Constraint reduction for inequalities with infinite RHS (#115)

* internal changes for sdp efficiency and rust compatibility

* Constructor float type defaults (fixes #117)
@goulart-paul goulart-paul deleted the pg/inf_bounds branch March 21, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants