Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iterative refinement edge case #128

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

goulart-paul
Copy link
Member

Fixes an edge case in iterative refinement for KKT solves.

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Patch coverage: 72.34% and project coverage change: -1.19 ⚠️

Comparison is base (50b0c6e) 82.22% compared to head (ba06cdd) 81.04%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   82.22%   81.04%   -1.19%     
==========================================
  Files          37       39       +2     
  Lines        2701     2817     +116     
==========================================
+ Hits         2221     2283      +62     
- Misses        480      534      +54     
Impacted Files Coverage Δ
src/cones/coneops_defaults.jl 15.55% <0.00%> (-7.18%) ⬇️
src/equilibration.jl 97.95% <ø> (ø)
src/precompile.jl 0.00% <0.00%> (ø)
src/settings.jl 4.44% <0.00%> (-3.56%) ⬇️
src/variables.jl 77.64% <ø> (+11.64%) ⬆️
src/version.jl 28.57% <0.00%> (ø)
src/Clarabel.jl 55.55% <42.85%> (-44.45%) ⬇️
src/utils/mathutils.jl 81.59% <50.00%> (+4.39%) ⬆️
src/types.jl 85.71% <70.00%> (-0.65%) ⬇️
src/MOI_wrapper/MOI_wrapper.jl 85.11% <85.71%> (+0.14%) ⬆️
... and 16 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@goulart-paul goulart-paul merged commit 16bda87 into main Jun 2, 2023
@goulart-paul goulart-paul deleted the pg/iterative_refinement_fix branch June 2, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants