-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clickhouse] Clickana monitoring dashboard tool #7207
base: main
Are you sure you want to change the base?
Conversation
@@ -1200,7 +1200,7 @@ pub enum Timestamp { | |||
#[derive(Debug, Serialize, Deserialize, JsonSchema, PartialEq)] | |||
#[serde(rename_all = "snake_case")] | |||
pub struct SystemTimeSeries { | |||
pub time: Timestamp, | |||
pub time: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is seriously doing my head in. Since Timestamp is an untagged enum, serde is having a hard time deserializing. My custom deserializer didn't work, but I'll see if I can find a way
// The ClickHouse client connects via the TCP port | ||
let ch_address = { | ||
let mut addr = *address; | ||
addr.set_port(CLICKHOUSE_TCP_PORT); | ||
addr.to_string() | ||
}; | ||
|
||
let clickhouse_admin_config = | ||
PropertyGroupBuilder::new("config") | ||
.add_property("http_address", "astring", admin_address) | ||
.add_property( | ||
"ch_address", | ||
"astring", | ||
address.to_string(), | ||
ch_address.to_string(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure when this broke, but it wouldn't have been caught as nothing was calling clickhouse_cli
(a wrapper around the clickhouse client
command) yet.
Overview
As part of Stage 1 of RFD468 we'll be observing how a ClickHouse cluster behaves in comparison with a single node server. This commit introduces a basic tool that lets us visualize internal ClickHouse metric information.
As a starting point, Clickana only has 4 charts, and the user may not choose what these are. Additionally, it is only capable of rendering data by making API calls. I'd like to make the tool more flexible; other capabilities will be added in follow up PRs.
Usage
Manual Testing
Next Steps
Related: #6953