Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fully qualify types and traits #647

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fully qualify types and traits #647

merged 1 commit into from
Aug 8, 2024

Conversation

ahl
Copy link
Collaborator

@ahl ahl commented Aug 8, 2024

Closes #646

sunshowers
sunshowers approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@sunshowers sunshowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ahl ahl merged commit 01f3e26 into main Aug 8, 2024
4 checks passed
@ahl ahl deleted the fully-qualify branch August 8, 2024 17:21
@anelson anelson mentioned this pull request Dec 1, 2024
Merged
@ahl ahl mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunshowers sunshowers sunshowers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

References to serde are only _mostly_ fully-qualified
2 participants
@ahl @sunshowers