Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo-release and bump minor versions #153

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Use cargo-release and bump minor versions #153

merged 2 commits into from
Jan 8, 2024

Conversation

bnaecker
Copy link
Collaborator

@bnaecker bnaecker commented Jan 2, 2024

No description provided.

@bnaecker bnaecker requested a review from ahl January 2, 2024 20:16
@bnaecker
Copy link
Collaborator Author

bnaecker commented Jan 2, 2024

I'm getting set up with cargo release to help address #8. We don't really need a tool for managing all this yet, since this commit is literally just cargo release version minor --execute. We may want to exclude the test crates from this process, but I don't see much harm in bumping those at the same time.

Copy link
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we set all crates we don't intend to publish to "0.0.0" and put a file like this in the directory: https://github.com/oxidecomputer/progenitor/blob/main/example-build/release.toml

usdt/Cargo.toml Show resolved Hide resolved
@bnaecker
Copy link
Collaborator Author

bnaecker commented Jan 8, 2024

Good idea, thanks @ahl. After ignoring all the internal crates, here's what cargo release will do:

bnaecker@shale : ~/usdt $ cargo release version minor
   Upgrading dof from 0.3.0 to 0.4.0
    Updating usdt's dependency from =0.3.0 to =0.4.0
    Updating usdt-impl's dependency from =0.3.0 to =0.4.0
    Updating usdt-impl's dependency from =0.3.0 to =0.4.0
   Upgrading dtrace-parser from 0.2.0 to 0.3.0
    Updating usdt's dependency from =0.2.0 to =0.3.0
    Updating usdt-attr-macro's dependency from =0.2.0 to =0.3.0
    Updating usdt-impl's dependency from =0.2.0 to =0.3.0
    Updating usdt-macro's dependency from =0.2.0 to =0.3.0
   Upgrading usdt-impl from 0.5.0 to 0.6.0
    Updating usdt's dependency from =0.5.0 to =0.6.0
    Updating usdt-attr-macro's dependency from =0.5.0 to =0.6.0
    Updating usdt-macro's dependency from =0.5.0 to =0.6.0
   Upgrading usdt-attr-macro from 0.5.0 to 0.6.0
    Updating usdt's dependency from =0.5.0 to =0.6.0
   Upgrading usdt-macro from 0.5.0 to 0.6.0
    Updating usdt's dependency from =0.5.0 to =0.6.0
   Upgrading usdt from 0.5.0 to 0.6.0
warning: aborting release due to dry run; re-run with `--execute`

That's what I really want, and still no need for a script or tool to run that.

- Add `release.toml` to all internal crates that prevents `cargo
  release` from operating on it.
- Set all internal crates to version `0.0.0`
@bnaecker bnaecker merged commit d18270e into master Jan 8, 2024
11 checks passed
@bnaecker bnaecker deleted the cargo-release branch January 8, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants