Add both path and version dependencies #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit removed the version specification for the path dependencies in the repository. This all works fine, until the crates are published. Crates on crates.io may not have path dependencies, but there is no version to use. The accepted solution appears to be to specify _both_ path and version dependencies. The former is used when building from source, the latter when publishing.
gjcolombo
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
LGTM with one small comment.
I did a little browsing, and it looks like cargo package can help detect the "no version information" case; if I run it against master I get errors of the following form:
error: all dependencies must have a version specified when packaging.
dependency `dtrace-parser` does not specify a version
Note: The packaged dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.
If I run it against the published packages in this branch, I get different errors about unsatisfiable dependencies, but I think that's expected and can be resolved by publishing things in the right order. (For example, usdt-macro complains about not being able to find dtrace-parser 0.1.14, which makes sense since it's not published yet.)
gjcolombo
reviewed
Nov 22, 2022
|
New changes LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit removed the version specification for the path dependencies in the repository. This all works fine, until the crates are published. Crates on crates.io may not have path dependencies, but there is no version to use.
The accepted solution appears to be to specify both path and version dependencies. The former is used when building from source, the latter when publishing.