Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for asm_sym stabilization in 1.66 #71

Merged
merged 19 commits into from
Dec 15, 2022
Merged

updates for asm_sym stabilization in 1.66 #71

merged 19 commits into from
Dec 15, 2022

Conversation

ahl
Copy link
Collaborator

@ahl ahl commented Dec 14, 2022

asm_sym is stable in 1.66; woohoo!

Bunch of doc cleanup with regard to required features.

CI runs for stable, stable w/o probes, recent nightly, old-ass nightly.

Fixes an issue where we were omitting the asm feature for an older nightly.

Once 1.66 is out (tomorrow) I need to

  • check in rust-toolchain.toml
  • update rust.yml

@pfmooney and I discussed the possibility of making this a major release and of ending support for pre 1.66 releases. We decided that this version should enable post-1.66 stable use of usdt, but also let people straddle that divide with older nightlies for example. In about 3-6 months, we should target a 1.0.0 release that has an MSRV of 1.66.

@ahl ahl requested review from pfmooney and bnaecker and removed request for pfmooney December 14, 2022 22:30
@ahl ahl marked this pull request as ready for review December 15, 2022 17:35
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent! A few questions / comments around the documentation changes, but looks great.

.github/workflows/rust.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
usdt/src/lib.rs Outdated Show resolved Hide resolved
usdt/src/lib.rs Outdated Show resolved Hide resolved
usdt/src/lib.rs Outdated Show resolved Hide resolved
@bnaecker bnaecker self-requested a review December 15, 2022 18:26
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ahl ahl merged commit 804f113 into master Dec 15, 2022
@ahl ahl deleted the stable branch December 15, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants