Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/mutated vowel #57

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Bug/mutated vowel #57

merged 2 commits into from
Feb 29, 2024

Conversation

mabiede
Copy link
Contributor

@mabiede mabiede commented Feb 29, 2024

Currently, the mutated vowels in the email subject aren't displayed correctly. The character ä results in 195\131\194\164 instead of \195\164.

  • use containers CCUtf8_string for unicode conversion and stay with Unconstructed.Craft function as a fallback
  • update devcontainer config and OCaml version
  • update package-lock file

@aronerben review requested ;-)

@aronerben
Copy link
Contributor

@mabiede Thanks for the fix!

@aronerben aronerben merged commit c38446b into oxidizing:master Feb 29, 2024
4 checks passed
@mabiede mabiede deleted the bug/mutated-vowel branch March 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aronerben aronerben aronerben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabiede @aronerben