Remove special handling of multiple inputs to pullbacks from ChainRules #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtebbutt
reviewed
May 20, 2020
oxinabox
commented
May 20, 2020
willtebbutt
reviewed
May 20, 2020
Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk>
oxinabox
added a commit
that referenced
this pull request
May 21, 2020
…es (#1) * ChainRules pullbacks always have 1 input JuliaDiff/ChainRulesCore.jl#152 * swap to version of chainrules that don't use multiarg pullbacks * update tests * make so don't need custom rule anymore * add comment * Update src/compiler/chainrules.jl Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk> Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk>
oxinabox
added a commit
that referenced
this pull request
May 21, 2020
…es (#1) * ChainRules pullbacks always have 1 input JuliaDiff/ChainRulesCore.jl#152 * swap to version of chainrules that don't use multiarg pullbacks * update tests * make so don't need custom rule anymore * add comment * Update src/compiler/chainrules.jl Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk> Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk>
oxinabox
added a commit
that referenced
this pull request
May 21, 2020
…es (#1) * ChainRules pullbacks always have 1 input JuliaDiff/ChainRulesCore.jl#152 * swap to version of chainrules that don't use multiarg pullbacks * update tests * make so don't need custom rule anymore * add comment * Update src/compiler/chainrules.jl Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk> Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk>
oxinabox
added a commit
that referenced
this pull request
May 28, 2020
…es (#1) * ChainRules pullbacks always have 1 input JuliaDiff/ChainRulesCore.jl#152 * swap to version of chainrules that don't use multiarg pullbacks * update tests * make so don't need custom rule anymore * add comment * Update src/compiler/chainrules.jl Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk> Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR against FluxML#366
However, it needs a bunch of other stuff to be tagged first.
So it should not be treated as blocking FluxML#366 as that might be a while.
I have tested it locally,
it does give a bit of a performance boost.
(Not huge but a bit)
Mostly it makes the code cleaner.