Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python version #2312

Merged
merged 11 commits into from
Feb 6, 2023
Merged

Upgrade python version #2312

merged 11 commits into from
Feb 6, 2023

Conversation

nvuillam
Copy link
Member

@nvuillam nvuillam commented Feb 5, 2023

No description provided.

@nvuillam
Copy link
Member Author

nvuillam commented Feb 5, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.02s
✅ BASH shellcheck 7 0 0.48s
✅ BASH shfmt 7 0 0 0.39s
✅ COPYPASTE jscpd yes no 2.79s
✅ DOCKERFILE hadolint 105 0 10.26s
✅ JSON eslint-plugin-jsonc 21 0 0 2.9s
✅ JSON jsonlint 19 0 0.28s
✅ JSON v8r 21 0 14.78s
⚠️ MARKDOWN markdownlint 309 0 229 7.31s
✅ MARKDOWN markdown-link-check 309 0 6.11s
✅ MARKDOWN markdown-table-formatter 309 0 0 22.24s
✅ OPENAPI spectral 1 0 0.86s
⚠️ PYTHON bandit 176 45 3.89s
✅ PYTHON black 176 0 0 4.83s
✅ PYTHON flake8 176 0 3.59s
✅ PYTHON isort 176 0 0 0.85s
✅ PYTHON mypy 176 0 7.68s
✅ PYTHON pylint 176 0 14.0s
⚠️ PYTHON pyright 176 276 20.63s
✅ REPOSITORY checkov yes no 31.89s
✅ REPOSITORY git_diff yes no 0.39s
✅ REPOSITORY secretlint yes no 9.26s
✅ REPOSITORY trivy yes no 28.48s
✅ SPELL cspell 730 0 22.64s
✅ SPELL misspell 551 0 0 0.91s
✅ XML xmllint 3 0 0 0.85s
✅ YAML prettier 81 0 0 3.54s
✅ YAML v8r 23 0 62.06s
✅ YAML yamllint 82 0 1.6s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator

echoix commented Feb 5, 2023

I think we'll need to take time to properly test that release out, since we are completely changing the available packages in the alpine repos and all. Plus the Python version.

@nvuillam
Copy link
Member Author

nvuillam commented Feb 5, 2023

I think we'll need to take time to properly test that release out, since we are completely changing the available packages in the alpine repos and all. Plus the Python version.

Agreed, as the latest release is today, it gives us time to check before the next one :)

@nvuillam nvuillam mentioned this pull request Feb 5, 2023
@bdovaz
Copy link
Collaborator

bdovaz commented Feb 5, 2023

@nvuillam I see that the php_psalm one has failed because of the API limit and that one in particular they comment that it is possible to pass an environment variable with the token to solve the problem:

phar-io/phive#127 (comment)

Would you know how to do it? Because being in the context of Docker I am not clear how to get that information and how to pass it.

@nvuillam
Copy link
Member Author

nvuillam commented Feb 5, 2023

The key is to solve the case for all linters, and to do that we must use official docker build action + manage all cases tht requires github auth ^^

@bdovaz
Copy link
Collaborator

bdovaz commented Feb 5, 2023

@nvuillam I have my doubts of if this concrete case that I mention is going to solve it with what you say... This case is seen to expressly use an environment variable with a very specific name:

https://github.com/phar-io/phive/blob/c5985a10f95be9a21b79e7ee19bef39dc85e9f95/src/shared/config/EnvironmentAuthConfig.php#L18

That is why I believe that this case should be treated differently and solved now with a PR if you think it is possible or create an issue if it is not feasible because it depends on other tasks.

What do you think about it?

@nvuillam
Copy link
Member Author

nvuillam commented Feb 5, 2023

If you find a way to solve it in a standalone PR, of course you can ^^
Plz update the doc to make sure users see it, especially if they are using gitlab or azure ^^

@bdovaz
Copy link
Collaborator

bdovaz commented Feb 5, 2023

If you find a way to solve it in a standalone PR, of course you can ^^ Plz update the doc to make sure users see it, especially if they are using gitlab or azure ^^

I think you didn't understand me or you didn't look at the links I posted.

The problem is in phive as I have put that is the one in charge of installing the mentioned PHP linter. That is, the problem is in the Dockerfile file when installing the linter through phive so we have to pass that environment variable to run in the GitHub workflows.

That is, we have to modify the descriptor to pass that environment variable to each phive command. Example:

RUN phive --no-progress install psalm -g --trust-gpg-keys 8A03EA3B385DBAA1,12CE0F1D262429A5

I have created #2314

@nvuillam
Copy link
Member Author

nvuillam commented Feb 6, 2023

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.02s
✅ BASH shellcheck 7 0 0.47s
✅ BASH shfmt 7 0 0 0.04s
✅ COPYPASTE jscpd yes no 2.85s
✅ DOCKERFILE hadolint 105 0 9.49s
✅ JSON eslint-plugin-jsonc 21 0 0 2.17s
✅ JSON jsonlint 19 0 0.28s
✅ JSON npm-package-json-lint yes no 0.8s
✅ JSON v8r 21 0 14.45s
⚠️ MARKDOWN markdownlint 309 2 229 6.92s
✅ MARKDOWN markdown-link-check 309 0 5.97s
✅ MARKDOWN markdown-table-formatter 309 2 0 17.43s
✅ OPENAPI spectral 1 0 1.09s
⚠️ PYTHON bandit 176 45 2.2s
✅ PYTHON black 176 0 0 3.56s
✅ PYTHON flake8 176 0 2.74s
✅ PYTHON isort 176 0 0 0.57s
✅ PYTHON mypy 176 0 8.95s
✅ PYTHON pylint 176 0 13.55s
⚠️ PYTHON pyright 176 274 21.85s
❌ REPOSITORY checkov yes 19 33.24s
⚠️ REPOSITORY devskim yes 61 1.59s
✅ REPOSITORY dustilock yes no 1.63s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 8.87s
✅ REPOSITORY syft yes no 3.7s
✅ REPOSITORY trivy yes no 20.85s
✅ SPELL cspell 730 0 22.84s
✅ SPELL misspell 551 2 0 0.61s
✅ XML xmllint 3 0 0 0.03s
✅ YAML prettier 81 0 0 2.83s
✅ YAML v8r 23 0 64.08s
✅ YAML yamllint 82 0 1.99s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants