Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update editorconfig-checker to 2.7.0 (refs #1282) #2349

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Update editorconfig-checker to 2.7.0 (refs #1282) #2349

merged 2 commits into from
Feb 12, 2023

Conversation

rasa
Copy link
Contributor

@rasa rasa commented Feb 11, 2023

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@rasa rasa requested a review from nvuillam as a code owner February 11, 2023 17:15
nvuillam
nvuillam approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)
I suspect you did not use bash build.sh , but in that case it will work anyway , so once CI is ok it can be merged :)

@nvuillam nvuillam enabled auto-merge (squash) February 11, 2023 17:21
@rasa
Copy link
Contributor Author

rasa commented Feb 11, 2023

I suspect you did not use bash build.sh...

@nvuillam I didn't, my bad, sorry. Happy to close the PR and submit a new one that follows the program, if you prefer.

@nvuillam
Copy link
Member

In that case it will do the same: read the yml descriptor file and propagate to all others, so it will be ok , u'll just know for next time:)

auto-merge was automatically disabled February 12, 2023 03:59

Head branch was pushed to by a user without write access

@nvuillam nvuillam merged commit 5c48e0f into oxsecurity:main Feb 12, 2023
@Kurt-von-Laven
Copy link
Collaborator

Related to #1282

@rasa rasa deleted the rasa/update-editorconfig branch February 13, 2023 15:46
This was referenced Aug 31, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvuillam nvuillam nvuillam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasa @nvuillam @Kurt-von-Laven