Fix npm permissions in v6.20.0 #2434

.automation/build.py

@@ -470,11 +470,12 @@ def build_dockerfile(
     if len(npm_packages) > 0:
         npm_install_command = (
             "WORKDIR /node-deps\n"
-            + "RUN npm --no-cache install --force --ignore-scripts \\\n                "
+            + "RUN npm --no-cache install --ignore-scripts --omit=dev \\\n                "
             + " \\\n                ".join(list(dict.fromkeys(npm_packages)))
-            + " && \\\n"
-            + "    npm audit fix --audit-level=critical || true \\\n"
+            + "  && \\\n"
+            + "       npm audit fix --audit-level=critical || true \\\n"
             + "    && npm cache clean --force || true \\\n"
+            + '    && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \\\n'
             + "    && rm -rf /root/.npm/_cacache \\\n"
             + '    && find . -name "*.d.ts" -delete \\\n'
             + '    && find . -name "*.map" -delete \\\n'

.automation/generated/flavors-stats.json

@@ -1349,8 +1349,8 @@
             2804650
         ],
         [
-            "2023-03-07T17:28:22",
-            2807613
+            "2023-03-07T19:21:17",
+            2807735
         ]
     ],
     "ci_light": [
@@ -2703,8 +2703,8 @@
             50967
         ],
         [
-            "2023-03-07T17:28:22",
-            51262
+            "2023-03-07T19:21:17",
+            51267
         ]
     ],
     "cupcake": [
@@ -3037,7 +3037,7 @@
             3903
         ],
         [
-            "2023-03-07T17:28:22",
+            "2023-03-07T19:21:17",
             4018
         ]
     ],
@@ -5301,8 +5301,8 @@
             120908
         ],
         [
-            "2023-03-07T17:28:22",
-            121391
+            "2023-03-07T19:21:17",
+            121401
         ]
     ],
     "dotnet": [
@@ -6655,8 +6655,8 @@
             354287
         ],
         [
-            "2023-03-07T17:28:22",
-            354806
+            "2023-03-07T19:21:17",
+            354845
         ]
     ],
     "go": [
@@ -8009,7 +8009,7 @@
             17265
         ],
         [
-            "2023-03-07T17:28:22",
+            "2023-03-07T19:21:17",
             17352
         ]
     ],
@@ -9363,8 +9363,8 @@
             110737
         ],
         [
-            "2023-03-07T17:28:22",
-            110909
+            "2023-03-07T19:21:17",
+            110911
         ]
     ],
     "javascript": [
@@ -10717,8 +10717,8 @@
             210747
         ],
         [
-            "2023-03-07T17:28:22",
-            211884
+            "2023-03-07T19:21:17",
+            211936
         ]
     ],
     "php": [
@@ -12071,7 +12071,7 @@
             46936
         ],
         [
-            "2023-03-07T17:28:22",
+            "2023-03-07T19:21:17",
             46962
         ]
     ],
@@ -13425,8 +13425,8 @@
             166786
         ],
         [
-            "2023-03-07T17:28:22",
-            167860
+            "2023-03-07T19:21:17",
+            167933
         ]
     ],
     "ruby": [
@@ -14775,7 +14775,7 @@
             3097
         ],
         [
-            "2023-03-07T17:28:22",
+            "2023-03-07T19:21:17",
             3109
         ]
     ],
@@ -16125,7 +16125,7 @@
             4709
         ],
         [
-            "2023-03-07T17:28:22",
+            "2023-03-07T19:21:17",
             4727
         ]
     ],
@@ -17479,7 +17479,7 @@
             17139
         ],
         [
-            "2023-03-07T17:28:22",
+            "2023-03-07T19:21:17",
             17240
         ]
     ],
@@ -18831,7 +18831,7 @@
             3593
         ],
         [
-            "2023-03-07T17:28:22",
+            "2023-03-07T19:21:17",
             3777
         ]
     ],
@@ -20181,7 +20181,7 @@
             3242
         ],
         [
-            "2023-03-07T17:28:22",
+            "2023-03-07T19:21:17",
             3253
         ]
     ],
@@ -21535,8 +21535,8 @@
             186856
         ],
         [
-            "2023-03-07T17:28:22",
-            187658
+            "2023-03-07T19:21:17",
+            187690
         ]
     ]
 }

.github/workflows/deploy-BETA-flavors.yml

@@ -102,6 +102,9 @@ jobs:
           username: ${{ github.repository_owner }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Get current date
+        run: echo "BUILD_DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ')" >> ${GITHUB_ENV}
+
       - name: Build Image
         uses: docker/build-push-action@v4
         with:

.github/workflows/deploy-BETA-linters.yml

@@ -214,6 +214,9 @@ jobs:
           username: ${{ github.repository_owner }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Get current date
+        run: echo "BUILD_DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ')" >> ${GITHUB_ENV}
+
       - name: Build Image
         uses: docker/build-push-action@v4
         with:

.github/workflows/deploy-BETA.yml

@@ -90,6 +90,9 @@ jobs:
           username: ${{ github.repository_owner }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Get current date
+        run: echo "BUILD_DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ')" >> ${GITHUB_ENV}
+
       - name: Build & Push Docker Image
         uses: docker/build-push-action@v4
         with:

.github/workflows/deploy-DEV-linters.yml

@@ -207,6 +207,9 @@ jobs:
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v2
 
+      - name: Get current date
+        run: echo "BUILD_DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ')" >> ${GITHUB_ENV}
+
       - name: Build Image
         uses: docker/build-push-action@v4
         with:

CHANGELOG.md

@@ -9,7 +9,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 Note: Can be used with `oxsecurity/megalinter@beta` in your GitHub Action mega-linter.yml file, or with `oxsecurity/megalinter:beta` docker image
 
 - Fixes
-  - Fix issue with running on Mac m1 no longer working [#2427](https://github.com/oxsecurity/megalinter/issues/2427)
+  - Fix [issue with running on Mac m1 no longer working](https://github.com/oxsecurity/megalinter/issues/2427), by @nvuillam
+  - Fix [Container images errors when pulling](https://github.com/oxsecurity/megalinter/issues/2348), by @echoix
+  - Fix [Pre npm install not resolving](https://github.com/oxsecurity/megalinter/issues/2428), by @echoix
+  - Add build date in Beta docker images, by @nvuillam
   - Correct misleading error message in **GitlabCommentReporter.py**, see [#2420](https://github.com/oxsecurity/megalinter/issues/2420)
   - Fix **GitlabCommentReporter** wrong variables names, check [#2423](https://github.com/oxsecurity/megalinter/issues/2423)
 

Dockerfile

@@ -189,14 +189,13 @@ ENV NODE_OPTIONS="--max-old-space-size=8192" \
     NODE_ENV=production
 #NPM__START
 WORKDIR /node-deps
-RUN npm --no-cache install --force --ignore-scripts \
+RUN npm --no-cache install --ignore-scripts --omit=dev \
                 sfdx-cli \
                 typescript \
                 @coffeelint/cli \
                 jscpd \
                 stylelint \
                 stylelint-config-standard \
-                stylelint-config-sass-guidelines \
                 stylelint-scss \
                 gherkin-lint \
                 graphql \
@@ -238,9 +237,10 @@ RUN npm --no-cache install --force --ignore-scripts \
                 tekton-lint \
                 prettyjson \
                 @typescript-eslint/eslint-plugin \
-                @typescript-eslint/parser && \
-    npm audit fix --audit-level=critical || true \
+                @typescript-eslint/parser  && \
+       npm audit fix --audit-level=critical || true \
     && npm cache clean --force || true \
+    && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \

README.md

@@ -1032,8 +1032,7 @@ You can show MegaLinter status with a badge in your repository README
 
 [![MegaLinter](https://github.com/oxsecurity/megalinter/workflows/MegaLinter/badge.svg?branch=main)](https://github.com/oxsecurity/megalinter/actions?query=workflow%3AMegaLinter+branch%3Amain)
 
-If your main branch is **main** , replace **main** by **main** in URLs
-
+_If your main branch is **master** , replace **main** by **master** in URLs_
 ### Markdown
 
 - Format

docs/badge.md

@@ -12,8 +12,7 @@ You can show MegaLinter status with a badge in your repository README
 
 [![MegaLinter](https://github.com/oxsecurity/megalinter/workflows/MegaLinter/badge.svg?branch=main)](https://github.com/oxsecurity/megalinter/actions?query=workflow%3AMegaLinter+branch%3Amain)
 
-If your main branch is **master** , replace **main** by **master** in URLs
-
+_If your main branch is **master** , replace **main** by **master** in URLs_
 ## Markdown
 
 - Format

docs/descriptors/css_stylelint.md

@@ -270,5 +270,4 @@ stylelint --fix --config .stylelintrc.json myfile.css myfile2.css myfile3.css
 - NPM packages (node.js):
   - [stylelint](https://www.npmjs.com/package/stylelint)
   - [stylelint-config-standard](https://www.npmjs.com/package/stylelint-config-standard)
-  - [stylelint-config-sass-guidelines](https://www.npmjs.com/package/stylelint-config-sass-guidelines)
   - [stylelint-scss](https://www.npmjs.com/package/stylelint-scss)

docs/installation.md

@@ -164,7 +164,7 @@ mega-linter:
     expire_in: 1 week
 ```
 
-Create a Gitlab access token and define it in a variable **GITLAB_ACCESS_TOKEN_MEGALINTER** in the project CI/CD masked variables
+Create a Gitlab access token and define it in a variable **GITLAB_ACCESS_TOKEN_MEGALINTER** in the project CI/CD masked variables. Make sure your token (e.g. if a project token) as the appropriate [role](https://docs.gitlab.com/ee/user/permissions.html) for commenting a merge request (at least developer).
 
 ![config-gitlab-access-token](https://user-images.githubusercontent.com/17500430/151674446-1bcb1420-d9aa-4ae1-aaae-dcf51afb36ab.gif)
 

docs/reporters/GitlabCommentReporter.md

@@ -20,13 +20,13 @@ Click on hyperlinks to access detailed logs (click on **Download** in **Artifact
 
 ![config-gitlab-access-token](https://user-images.githubusercontent.com/17500430/151674446-1bcb1420-d9aa-4ae1-aaae-dcf51afb36ab.gif)
 
-| Variable                       | Description                                                                                            | Default value            |
-|--------------------------------|--------------------------------------------------------------------------------------------------------|--------------------------|
-| GITLAB_COMMENT_REPORTER        | Activates/deactivates reporter                                                                         | true                     |
-| GITLAB_ACCESS_TOKEN_MEGALINTER | Must contain a Gitlab private access token defined with api access                                     | <!-- -->                 |
-| GITLAB_CUSTOM_CERTIFICATE      | SSL certificate value to connect to Gitlab                                                             | <!-- -->                 |
-| GITLAB_CERTIFICATE_PATH        | Path to SSL certificate to connect to Gitlab (if SSL cert has been manually defined with PRE_COMMANDS) | <!-- -->                 |
-| REPORTERS_MARKDOWN_TYPE        | Set to `simple` to avoid external images in generated markdown                                         | `advanced`               |
+| Variable                       | Description                                                                                            | Default value |
+|--------------------------------|--------------------------------------------------------------------------------------------------------|---------------|
+| GITLAB_COMMENT_REPORTER        | Activates/deactivates reporter                                                                         | true          |
+| GITLAB_ACCESS_TOKEN_MEGALINTER | Must contain a Gitlab private access token defined with api access                                     | <!-- -->      |
+| GITLAB_CUSTOM_CERTIFICATE      | SSL certificate value to connect to Gitlab                                                             | <!-- -->      |
+| GITLAB_CERTIFICATE_PATH        | Path to SSL certificate to connect to Gitlab (if SSL cert has been manually defined with PRE_COMMANDS) | <!-- -->      |
+| REPORTERS_MARKDOWN_TYPE        | Set to `simple` to avoid external images in generated markdown                                         | `advanced`    |
 
 ## Special Thanks
 

flavors/ci_light/Dockerfile

@@ -103,7 +103,7 @@ ENV NODE_OPTIONS="--max-old-space-size=8192" \
     NODE_ENV=production
 #NPM__START
 WORKDIR /node-deps
-RUN npm --no-cache install --force --ignore-scripts \
+RUN npm --no-cache install --ignore-scripts --omit=dev \
                 jscpd \
                 npm-groovy-lint \
                 @prantlf/jsonlint \
@@ -114,9 +114,10 @@ RUN npm --no-cache install --force --ignore-scripts \
                 prettier \
                 secretlint \
                 @secretlint/secretlint-rule-preset-recommend \
-                @secretlint/secretlint-formatter-sarif && \
-    npm audit fix --audit-level=critical || true \
+                @secretlint/secretlint-formatter-sarif  && \
+       npm audit fix --audit-level=critical || true \
     && npm cache clean --force || true \
+    && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \

flavors/cupcake/Dockerfile

@@ -154,12 +154,11 @@ ENV NODE_OPTIONS="--max-old-space-size=8192" \
     NODE_ENV=production
 #NPM__START
 WORKDIR /node-deps
-RUN npm --no-cache install --force --ignore-scripts \
+RUN npm --no-cache install --ignore-scripts --omit=dev \
                 typescript \
                 jscpd \
                 stylelint \
                 stylelint-config-standard \
-                stylelint-config-sass-guidelines \
                 stylelint-scss \
                 graphql \
                 graphql-schema-linter \
@@ -198,9 +197,10 @@ RUN npm --no-cache install --force --ignore-scripts \
                 sql-lint \
                 prettyjson \
                 @typescript-eslint/eslint-plugin \
-                @typescript-eslint/parser && \
-    npm audit fix --audit-level=critical || true \
+                @typescript-eslint/parser  && \
+       npm audit fix --audit-level=critical || true \
     && npm cache clean --force || true \
+    && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \

flavors/documentation/Dockerfile

@@ -119,11 +119,10 @@ ENV NODE_OPTIONS="--max-old-space-size=8192" \
     NODE_ENV=production
 #NPM__START
 WORKDIR /node-deps
-RUN npm --no-cache install --force --ignore-scripts \
+RUN npm --no-cache install --ignore-scripts --omit=dev \
                 jscpd \
                 stylelint \
                 stylelint-config-standard \
-                stylelint-config-sass-guidelines \
                 stylelint-scss \
                 graphql \
                 graphql-schema-linter \
@@ -144,9 +143,10 @@ RUN npm --no-cache install --force --ignore-scripts \
                 @secretlint/secretlint-formatter-sarif \
                 cspell \
                 sql-lint \
-                tekton-lint && \
-    npm audit fix --audit-level=critical || true \
+                tekton-lint  && \
+       npm audit fix --audit-level=critical || true \
     && npm cache clean --force || true \
+    && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \