Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace babel-eslint with @babel/eslint-parser #2445

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Mar 8, 2023

Fixes #2444

@bdovaz bdovaz requested a review from nvuillam as a code owner March 8, 2023 07:42
@bdovaz
Copy link
Collaborator Author

bdovaz commented Mar 8, 2023

/build

Command run output
Build command workflow started.
Installing dependencies
Running script ./build.sh
Build command workflow completed updating files.

@bdovaz
Copy link
Collaborator Author

bdovaz commented Mar 8, 2023

@echoix how to run /build? I saw you this comment: #2406 (comment)

But it doesn't work for me, it doesn't do anything. Do I have to do something different?

I have not launched in my build.sh branch on purpose to test this new flow.

Edit: Ok, that's it, it just took a while to run.

@nvuillam
Copy link
Member

nvuillam commented Mar 8, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.03s
✅ BASH shellcheck 6 0 0.35s
✅ BASH shfmt 6 0 0 0.42s
✅ COPYPASTE jscpd yes no 2.99s
✅ DOCKERFILE hadolint 114 0 19.04s
✅ JSON eslint-plugin-jsonc 21 0 0 2.63s
✅ JSON jsonlint 19 0 0.22s
✅ JSON v8r 21 0 13.88s
⚠️ MARKDOWN markdownlint 309 0 230 7.97s
✅ MARKDOWN markdown-link-check 309 0 6.62s
✅ MARKDOWN markdown-table-formatter 309 0 0 22.45s
✅ OPENAPI spectral 1 0 1.55s
⚠️ PYTHON bandit 183 47 3.98s
✅ PYTHON black 183 0 0 4.36s
✅ PYTHON flake8 183 0 2.05s
✅ PYTHON isort 183 0 0 1.6s
✅ PYTHON mypy 183 0 7.97s
✅ PYTHON pylint 183 0 13.38s
⚠️ PYTHON pyright 183 250 18.43s
✅ REPOSITORY checkov yes no 34.45s
✅ REPOSITORY git_diff yes no 0.42s
✅ REPOSITORY secretlint yes no 16.67s
✅ REPOSITORY trivy yes no 35.68s
✅ SPELL cspell 745 0 24.09s
✅ SPELL misspell 566 0 0 1.06s
✅ XML xmllint 3 0 0 0.45s
✅ YAML prettier 81 0 0 3.37s
✅ YAML v8r 23 0 61.19s
✅ YAML yamllint 82 0 1.29s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@bdovaz
Copy link
Collaborator Author

bdovaz commented Mar 8, 2023

@echoix but there is one thing I don't quite understand.

I thought that command was to create an additional commit with the build.sh changes in my branch and not in the main branch.

Because for example in my PR that only affects descriptors, the checks only make sense to be executed if I run build.sh by hand before and commit the changes in my branch so that it modifies the Dockerfile files.

image

cc @nvuillam @Kurt-von-Laven

@nvuillam
Copy link
Member

nvuillam commented Mar 8, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.16s
✅ BASH shfmt 6 0 0 0.05s
✅ COPYPASTE jscpd yes no 4.01s
✅ DOCKERFILE hadolint 114 0 19.4s
✅ JSON eslint-plugin-jsonc 21 0 0 2.42s
✅ JSON jsonlint 19 0 0.23s
✅ JSON npm-package-json-lint yes no 0.92s
✅ JSON v8r 21 0 15.42s
⚠️ MARKDOWN markdownlint 309 2 230 7.23s
✅ MARKDOWN markdown-link-check 309 0 6.11s
✅ MARKDOWN markdown-table-formatter 309 2 0 20.34s
✅ OPENAPI spectral 1 0 2.05s
⚠️ PYTHON bandit 183 47 3.43s
✅ PYTHON black 183 0 0 4.56s
✅ PYTHON flake8 183 0 4.23s
✅ PYTHON isort 183 0 0 0.6s
✅ PYTHON mypy 183 0 9.7s
✅ PYTHON pylint 183 0 14.65s
⚠️ PYTHON pyright 183 250 21.62s
✅ REPOSITORY checkov yes no 39.08s
⚠️ REPOSITORY devskim yes 61 1.59s
✅ REPOSITORY dustilock yes no 1.23s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 9.48s
✅ REPOSITORY syft yes no 1.15s
✅ REPOSITORY trivy yes no 30.25s
✅ SPELL cspell 745 0 28.98s
✅ SPELL misspell 566 2 0 0.7s
✅ XML xmllint 3 0 0 0.04s
✅ YAML prettier 81 0 0 3.46s
✅ YAML v8r 23 0 68.57s
✅ YAML yamllint 82 0 1.47s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator

echoix commented Mar 8, 2023

@echoix but there is one thing I don't quite understand.

I thought that command was to create an additional commit with the build.sh changes in my branch and not in the main branch.

Because for example in my PR that only affects descriptors, the checks only make sense to be executed if I run build.sh by hand before and commit the changes in my branch so that it modifies the Dockerfile files.

image

@bdovaz I know, I need another PR to use the correct branch for actions/checkout. In the meantime, add ref=branchname to the command. And in a PR, it can also be something like the branch name that starts with refs/... and has /pull/(pr number) but I don't remember the exact format.

And for the time it takes to start executing, if there's no runner left to start it, it can't start yet.

@echoix
Copy link
Collaborator

echoix commented Mar 8, 2023

/build ref=feature/replace-babel-eslint

Command run output
Build command workflow started.
Installing dependencies
Running script ./build.sh
Build command workflow completed updating files.

@bdovaz
Copy link
Collaborator Author

bdovaz commented Mar 8, 2023

@nvuillam this Trivy error, do you know it? It's the first time I see it.

image

@nvuillam
Copy link
Member

nvuillam commented Mar 8, 2023

@bdovaz timeout= ignore = force, it will work again before the next release:)
I'm more shocked by the 1h23 job...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace babel-eslint with @babel/eslint-parser
3 participants