Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify kubeconform install & get version #2629

Merged
merged 4 commits into from
May 13, 2023
Merged

Simplify kubeconform install & get version #2629

merged 4 commits into from
May 13, 2023

Conversation

nvuillam
Copy link
Member

No description provided.

@nvuillam
Copy link
Member Author

nvuillam commented May 13, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.13s
✅ BASH shfmt 6 0 0 0.41s
✅ COPYPASTE jscpd yes no 3.06s
✅ DOCKERFILE hadolint 118 0 14.56s
✅ JSON eslint-plugin-jsonc 23 0 0 3.63s
✅ JSON jsonlint 21 0 0.19s
✅ JSON v8r 23 0 14.97s
⚠️ MARKDOWN markdownlint 313 0 232 126.26s
✅ MARKDOWN markdown-link-check 313 0 5.96s
✅ MARKDOWN markdown-table-formatter 313 0 0 17.19s
✅ OPENAPI spectral 1 0 1.28s
⚠️ PYTHON bandit 192 58 2.14s
✅ PYTHON black 192 0 0 4.45s
✅ PYTHON flake8 192 0 1.92s
✅ PYTHON isort 192 0 0 0.85s
✅ PYTHON mypy 192 0 7.56s
✅ PYTHON pylint 192 0 12.47s
⚠️ PYTHON pyright 192 299 20.42s
✅ PYTHON ruff 192 0 0 0.48s
✅ REPOSITORY checkov yes no 31.6s
✅ REPOSITORY git_diff yes no 0.39s
✅ REPOSITORY secretlint yes no 12.32s
✅ REPOSITORY trivy yes no 27.14s
✅ SPELL cspell 621 0 25.61s
⚠️ SPELL vale 222 63 28.16s
✅ XML xmllint 3 0 0 0.42s
✅ YAML prettier 157 0 0 4.99s
✅ YAML v8r 99 0 136.15s
✅ YAML yamllint 158 0 1.5s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam
Copy link
Member Author

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.02s
✅ BASH shellcheck 6 0 0.18s
✅ BASH shfmt 6 0 0 0.04s
✅ COPYPASTE jscpd yes no 4.78s
✅ DOCKERFILE hadolint 118 0 23.3s
✅ JSON eslint-plugin-jsonc 23 0 0 3.15s
✅ JSON jsonlint 21 0 0.29s
✅ JSON npm-package-json-lint yes no 0.92s
✅ JSON v8r 23 0 18.44s
⚠️ MARKDOWN markdownlint 313 2 232 182.7s
✅ MARKDOWN markdown-link-check 313 0 6.5s
✅ MARKDOWN markdown-table-formatter 313 2 0 22.85s
✅ OPENAPI spectral 1 0 1.83s
⚠️ PYTHON bandit 192 58 4.58s
✅ PYTHON black 192 0 0 5.46s
✅ PYTHON flake8 192 0 2.64s
✅ PYTHON isort 192 0 0 0.71s
✅ PYTHON mypy 192 0 11.26s
✅ PYTHON pylint 192 0 17.87s
⚠️ PYTHON pyright 192 299 28.62s
✅ PYTHON ruff 192 0 0 0.19s
✅ REPOSITORY checkov yes no 43.06s
⚠️ REPOSITORY devskim yes 913 5.33s
✅ REPOSITORY dustilock yes no 2.44s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY secretlint yes no 17.82s
✅ REPOSITORY syft yes no 1.4s
✅ REPOSITORY trivy yes no 32.71s
✅ SPELL cspell 634 0 38.89s
⚠️ SPELL vale 222 63 37.61s
✅ XML xmllint 3 0 0 0.03s
✅ YAML prettier 157 0 0 5.01s
✅ YAML v8r 99 0 168.29s
✅ YAML yamllint 158 0 2.17s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit 5552375 into main May 13, 2023
@nvuillam nvuillam deleted the fixes/kubekonform branch May 13, 2023 21:41
Copy link
Collaborator

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing with go install, means we have to install the go compiler, and we have the build artifacts in the image.

Using a separate stage means faster build times too, since the compilation is decoupled from the main flow

@nvuillam
Copy link
Member Author

@echoix look here ;) #2637

@echoix
Copy link
Collaborator

echoix commented May 14, 2023

Ok, thanks! I didn't finish going through all the changes during the last day yet!

@nvuillam
Copy link
Member Author

nvuillam commented May 14, 2023

Ok, thanks! I didn't finish going through all the changes during the last day yet!

I decided the next release will be a v7 ... there are too many changes, some of them potentially breaking changes, so you and the team are right, let's respect SEMVER even if it's just by precaution :)

cc @bdovaz @Kurt-von-Laven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants