Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Features #47

Merged
merged 14 commits into from
Aug 29, 2024
Merged

Various Features #47

merged 14 commits into from
Aug 29, 2024

Conversation

wyne
Copy link
Contributor

@wyne wyne commented Aug 27, 2024

Summary

  • Fix: Update times as you move
  • New: Jump by day with H / L
  • New:Jump by week with < / >
  • New: Add -w for watch mode, updating every minute
  • New: Right align times for easier reading; add month and year
  • New: Press o to open in timeanddate.com
  • New: Press t to go to now

Demo

Top: Current
Bottom: New

tz2.mp4

Resolves #39
Resolves #40
Resolves #10

@oz
Copy link
Owner

oz commented Aug 27, 2024

Hi!

First, thanks for these changes, and recording a demo. 👍🏻

I really want to merge this, but I see a failing test right now. Something with date change not happening at midnight. I'll take a look later, unless you beat me to it.

@wyne
Copy link
Contributor Author

wyne commented Aug 27, 2024

It's probably my latest commit that resolved a bug where it would skip over a day at midnight (ex: Wed->Fri). So something is off between the UI and the test.

I'll take a look.

@wyne
Copy link
Contributor Author

wyne commented Aug 28, 2024

I was confused about the distinction between model.now and Now, so I consolidated the clocks into one unified clock. That made sense to me, but let me know if I'm missing something.

I'm still debugging the test though. I had it working at some point, but still hitting an issue even though it does work correctly in the TUI.

@wyne
Copy link
Contributor Author

wyne commented Aug 28, 2024

Ah, I figured it out in the latest commit. Lmk if you have a better idea. I don't do a lot of go programming :)

@oz
Copy link
Owner

oz commented Aug 29, 2024

Lmk if you have a better idea. I don't do a lot of go programming :)

Me neither lately. 😞

Alright. That PR works for me. Thanks a lot! 🙇🏻

@oz oz merged commit 51bf458 into oz:main Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants