Fix naming & build #569
Merged
Fix naming & build #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimalekseev
approved these changes
Jan 10, 2024
vadimalekseev
added a commit
that referenced
this pull request
Jan 12, 2024
* Some performance optimizations * Rename RenameReleaser -> MetricDeleter * Benchmark prometheus.MetricVec * Replace parallel benchmark with the loop * Fix string copy * Add tests for the HeldMetric * Fix naming & build (#569) * Fix naming & build * Rollback comment * Update MetricHolder test --------- Co-authored-by: Yaroslav Kirillov <kirillov.y6@gmail.com>
kirillov6
added a commit
that referenced
this pull request
Jan 31, 2024
* New metric holder * Rename metric.Ctl constructor * Fix prometheus import name * Fix build * Add tests * Refactor metric controller * Remove updateTime & beautify * Fix nowTime & tests * Refactor metric controller * Add xtime package * Use xtime in metric holder * Rework holder & wrappers * Rework * Fix go mod * Some performance optimizations to the MetricHolder (#568) * Some performance optimizations * Rename RenameReleaser -> MetricDeleter * Benchmark prometheus.MetricVec * Replace parallel benchmark with the loop * Fix string copy * Add tests for the HeldMetric * Fix naming & build (#569) * Fix naming & build * Rollback comment * Update MetricHolder test * Add metric_hold_duration to pipeline settings * go mod tidy * Fix tests * Fix after merge * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.