Skip to content

Commit

Permalink
Remove unnecessary connection_keep_alive method from peers behaviour
Browse files Browse the repository at this point in the history
  • Loading branch information
sandreae committed Jun 22, 2024
1 parent 888d63a commit 962f453
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions aquadoggo/src/network/peers/handler.rs
Original file line number Diff line number Diff line change
Expand Up @@ -227,14 +227,6 @@ impl ConnectionHandler for Handler {
}
}

fn connection_keep_alive(&self) -> bool {
if self.critical_error {
return false;
}

true
}

fn poll(
&mut self,
cx: &mut Context<'_>,
Expand Down Expand Up @@ -298,7 +290,7 @@ impl ConnectionHandler for Handler {
// Don't close the connection but just drop the inbound substream.
// In case the remote has more to send, they will open up a new
// substream.
warn!("Error during closing inbound connection: {err}")
warn!("Error during closing inbound connection: {err}");

Check warning on line 293 in aquadoggo/src/network/peers/handler.rs

View check run for this annotation

Codecov / codecov/patch

aquadoggo/src/network/peers/handler.rs#L293

Added line #L293 was not covered by tests
}
self.inbound_substream = None;
break;
Expand Down

0 comments on commit 962f453

Please sign in to comment.