Move SqlStorage into shared Context
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #135 +/- ##
===============================================
- Coverage 93.31% 93.25% -0.07%
===============================================
Files 26 26
Lines 1421 1423 +2
===============================================
+ Hits 1326 1327 +1
- Misses 95 96 +1
Continue to review full report at Codecov.
|
cafca
reviewed
Jun 13, 2022
Comment on lines
+42
to
+44
| // Load and return next entry arguments | ||
| let store = ctx.data::<SqlStorage>()?; | ||
| store.get_entry_args(&args).await.map_err(Error::from) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
SqlStorageinstance into the sharedContext, so we don't need to create a new one on every GraphQL request (and other future methods).Note: It is still possible to access the underlying connection pool object when needed as it is publicly exported inside the
SqlStorage.Closes: #134
📋 Checklist
CHANGELOG.md