Add service ready signal #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 93.70% 93.73% +0.02%
==========================================
Files 42 44 +2
Lines 3179 3496 +317
==========================================
+ Hits 2979 3277 +298
- Misses 200 219 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
adzialocha
requested changes
Aug 2, 2022
aquadoggo/src/http/service.rs
Outdated
| context: Context, | ||
| signal: Shutdown, | ||
| tx: ServiceSender, | ||
| tx_ready: oneshot::Sender<()>, |
There was a problem hiding this comment.
Maybe give the sender also an own type like you already do for the receiver (ServiceReady)? I think that would also ready easier as well.
This was referenced Aug 3, 2022
Closed
adzialocha
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services receive an additional parameter with a oneshot channel to which they send a unit value once they are ready to process messages on the communication bus. This allows us to understand when a service becomes ready from outside the service. Previously there were a couple of tests that waited for some arbitrary time to allow services to become available.
📋 Checklist
CHANGELOG.md