Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seqNum param need to be a string during replication #256

Merged
merged 4 commits into from
Sep 3, 2022
Merged

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Sep 2, 2022

Closes #199

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@adzialocha adzialocha marked this pull request as draft September 2, 2022 20:10
@adzialocha adzialocha marked this pull request as ready for review September 2, 2022 20:18
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #256 (32ca50b) into main (0bf77f5) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 32ca50b differs from pull request most recent head bb7a4b3. Consider uploading reports for the commit bb7a4b3 to get more accurate results

@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files          59       59           
  Lines        4924     4924           
=======================================
  Hits         4629     4629           
  Misses        295      295           
Impacted Files Coverage Δ
aquadoggo/src/graphql/replication/client.rs 85.71% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sandreae sandreae merged commit d96d60a into main Sep 3, 2022
@adzialocha adzialocha deleted the fix-seq-num branch September 3, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entriesNewerThanSeqNum pagination fails with parsing SeqNum
2 participants