Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap document insertion methods in transaction #259

Merged
merged 3 commits into from
Sep 4, 2022

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Sep 3, 2022

In insert_document perform two db insertions, these should be wrapped in a transaction.

Fix for: #254 and hopefully #247

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #259 (d4c4b09) into main (81a7bf7) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   94.02%   93.98%   -0.04%     
==========================================
  Files          59       59              
  Lines        4936     4940       +4     
==========================================
+ Hits         4641     4643       +2     
- Misses        295      297       +2     
Impacted Files Coverage Δ
aquadoggo/src/db/stores/document.rs 92.06% <50.00%> (-0.91%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adzialocha
Copy link
Member

hopefully #247

I've ran it locally and still got the failing tests 😿

But thanks for that fix 👍

@sandreae
Copy link
Member Author

sandreae commented Sep 3, 2022

I've ran it locally and still got the failing tests crying_cat_face

Boo! I ran it and didn't get fails... I was optimistic 😢

@adzialocha adzialocha merged commit 57cedd4 into main Sep 4, 2022
@adzialocha adzialocha deleted the add-transaction-to-insert-document branch September 4, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants