Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update breaking API calls for new p2panda-rs version #293

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Mar 16, 2023

In p2panda-rs version 0.7.0 we introduced new APIs around the creation of schemas and the storage provider traits which led to breaking code in aquadoggo. This PR updates everything to be compatible with the latest version.

Closes: #294

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@adzialocha adzialocha marked this pull request as ready for review March 16, 2023 11:24
@sandreae sandreae self-requested a review March 16, 2023 11:27
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 77.27% and project coverage change: -0.05 ⚠️

Comparison is base (6c6d15b) 91.42% compared to head (91de3b5) 91.38%.

❗ Current head 91de3b5 differs from pull request most recent head bc95f52. Consider uploading reports for the commit bc95f52 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   91.42%   91.38%   -0.05%     
==========================================
  Files          64       64              
  Lines        4644     4653       +9     
==========================================
+ Hits         4246     4252       +6     
- Misses        398      401       +3     
Impacted Files Coverage Δ
aquadoggo/src/db/types/document.rs 38.09% <0.00%> (-11.91%) ⬇️
aquadoggo/src/graphql/client/mutation.rs 100.00% <ø> (ø)
aquadoggo/src/db/stores/entry.rs 96.26% <100.00%> (ø)
aquadoggo/src/db/stores/log.rs 96.49% <100.00%> (+0.06%) ⬆️
aquadoggo/src/db/stores/schema.rs 96.22% <100.00%> (+0.07%) ⬆️
aquadoggo/src/graphql/client/dynamic_query.rs 96.37% <100.00%> (+0.01%) ⬆️
...doggo/src/graphql/client/dynamic_types/document.rs 100.00% <100.00%> (ø)
...quadoggo/src/graphql/client/dynamic_types/tests.rs 24.19% <100.00%> (+0.38%) ⬆️
aquadoggo/src/materializer/tasks/schema.rs 88.57% <100.00%> (ø)
aquadoggo/src/schema/schema_provider.rs 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sandreae sandreae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All looks good to me 👍

@adzialocha adzialocha merged commit a792dac into main Mar 16, 2023
@adzialocha adzialocha deleted the update-p2panda-rs-api branch March 16, 2023 11:35
adzialocha added a commit that referenced this pull request Mar 16, 2023
* main:
  Update breaking API calls for new `p2panda-rs` version (#293)
  Update Cargo.lock as well
  Use released p2panda-rs version 0.7.0
  Migrate CLI from `structopt` to `clap` (#289)
  Increase timeout for failing materializer test
  Introduce requeue flag (#286)
  Do transactions correctly (#285)
  Add libp2p service and configuration (#282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix breaking p2panda-rs API
2 participants